Fix next halving calculation #1

Open
opened 3 weeks ago by duke · 3 comments
duke commented 3 weeks ago
Owner

Currently the calculation for the next halving in src/controller.cpp is for Hush and incorrect for DragonX

Currently the calculation for the next halving in src/controller.cpp is for Hush and incorrect for DragonX
Collaborator

Thanks for fixing block time. Noticed this when looking into why other data is 0 or empty, but didn't get a chance to debug yet. This data should be fixed along with halving calculation.

Things like difficulty and longestchain seem to have been removed from GetLightdInfo endpoint in previous updates, if it ever displayed in the past.

Docs don't show this info returned:
https://zcash.readthedocs.io/en/latest/lightwalletd/index.html#cash.z.wallet.sdk.rpc.LightdInfo

Thanks for fixing block time. Noticed this when looking into why other data is 0 or empty, but didn't get a chance to debug yet. This data should be fixed along with halving calculation. Things like difficulty and longestchain seem to have been removed from `GetLightdInfo` endpoint in previous updates, if it ever displayed in the past. Docs don't show this info returned: https://zcash.readthedocs.io/en/latest/lightwalletd/index.html#cash.z.wallet.sdk.rpc.LightdInfo
Collaborator

I think it's correct now with first halving at height 3,500,000.

For other missing info, it seems it's being set here in sdxl-cli:
https://git.hush.is/dragonx/silentdragonxlite-cli/src/branch/master/lib/src/lightclient.rs#L720

I haven't checked if the issue exists in SDL or if maybe a specific option needs to be set in config for it to return additional data.

I think it's correct now with first halving at height 3,500,000. For other missing info, it seems it's being set here in sdxl-cli: https://git.hush.is/dragonx/silentdragonxlite-cli/src/branch/master/lib/src/lightclient.rs#L720 I haven't checked if the issue exists in SDL or if maybe a specific option needs to be set in config for it to return additional data.
Poster
Owner

@fekt I remember something about this stuff when I was making the last large update of lightwalletd code. Difficulty and longestchain used to work, but we were in the middle of testing lightwalletd changes and I decided to not deal with them at the time, so people could continue testing lightwalletd. Some part of the internals stopped passing the data to other parts of the code. I intended to fix it but forgot about it.

@fekt I remember something about this stuff when I was making the last large update of lightwalletd code. Difficulty and longestchain *used* to work, but we were in the middle of testing lightwalletd changes and I decided to not deal with them at the time, so people could continue testing lightwalletd. Some part of the internals stopped passing the data to other parts of the code. I intended to fix it but forgot about it.
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.