Camera does not work for QR code scanning when sending txs #1

Open
opened 1 year ago by fekt · 2 comments
fekt commented 1 year ago

App asks for camera permissions and permissions are granted, but only the "QR frame" displays. When checking logcat in Android Studio, it appears to detect and load the camera based on logs. Issue may be with the layout. Needs further investigation and testing in unmodified ECC wallet to see if it even works there. Code is based on these examples, which may have more recent updates:
https://github.com/android/camera-samples/tree/main/CameraXBasic

There are also additional samples there that may work better.

App asks for camera permissions and permissions are granted, but only the "QR frame" displays. When checking logcat in Android Studio, it appears to detect and load the camera based on logs. Issue may be with the layout. Needs further investigation and testing in unmodified ECC wallet to see if it even works there. Code is based on these examples, which may have more recent updates: https://github.com/android/camera-samples/tree/main/CameraXBasic There are also additional samples there that may work better.
fekt commented 1 year ago

I tried testing QR code scanning in ECC and Nighthawk wallets and it's near impossible from the tx spam and old checkpoints. I downloaded 13+ GB of data before it died. I'm thinking their camera code doesn't work either because they have comments saying Android kept making breaking changes.

The example code they reference is entirely different than what's in their apps now. I just updated most of the code and it at least loads the camera and shows in QR frame now. Need to port code for scanning and reading the code but it's some progress.

I tried testing QR code scanning in ECC and Nighthawk wallets and it's near impossible from the tx spam and old checkpoints. I downloaded 13+ GB of data before it died. I'm thinking their camera code doesn't work either because they have comments saying Android kept making breaking changes. The example code they reference is entirely different than what's in their apps now. I just updated most of the code and it at least loads the camera and shows in QR frame now. Need to port code for scanning and reading the code but it's some progress.
fekt commented 1 year ago

Believe this is fixed now but needs testing on different phones with different Android versions and screen sizes.

Believe this is fixed now but needs testing on different phones with different Android versions and screen sizes.
This repo is archived. You cannot comment on issues.
No Label
No Milestone
No project
No Assignees
1 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.