From 12407174315a14ecaaeb99c8fe912775c18679d9 Mon Sep 17 00:00:00 2001 From: practicalswift Date: Wed, 14 Jun 2017 17:32:45 +0200 Subject: [PATCH] Net: Fix resource leak in ReadBinaryFile(...) Introduced in 3290567bbd54e01cb6fe6b1d04c659abca983af2 via PR #2177. --- src/torcontrol.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/torcontrol.cpp b/src/torcontrol.cpp index a5cd1b7c6..ffa1f75f8 100644 --- a/src/torcontrol.cpp +++ b/src/torcontrol.cpp @@ -376,8 +376,10 @@ static std::pair ReadBinaryFile(const std::string &filename, s while ((n=fread(buffer, 1, sizeof(buffer), f)) > 0) { // Check for reading errors so we don't return any data if we couldn't // read the entire file (or up to maxsize) - if (ferror(f)) + if (ferror(f)) { + fclose(f); return std::make_pair(false,""); + } retval.append(buffer, buffer+n); if (retval.size() > maxsize) break;