hush
/
SilentDragon
9
1
Fork 7
Code Issues 73 Pull Requests 1 Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

add feature to view ASN via bgpview.io to banned hosts list #100

Open
opened 2 years ago by jahway603 · 5 comments
jahway603 commented 2 years ago
Collaborator

While testing banning and unbanning peers, I noticed that the feature to view ASN via bgpview.io to banned hosts list is missing. The shodan option is there.

While testing banning and unbanning peers, I noticed that the feature to view ASN via bgpview.io to banned hosts list is missing. The shodan option is there.
👍 1
duke commented 2 years ago
Owner

yes, good suggestion

yes, good suggestion
fekt commented 2 years ago
Collaborator

I noticed this in testing too. I tried adding code for it similar to peers table but it is not supported in listbanned RPC. Each table has its own model and uses a different RPC. getpeerinfo returns "mapped_as", which is also not documented in RPC docs. listbanned would probably need to return that for this to work. Right now it'll just use 0 and not link to anything.

I noticed this in testing too. I tried adding code for it similar to peers table but it is not supported in `listbanned` RPC. Each table has its own model and uses a different RPC. `getpeerinfo` returns "mapped_as", which is also not documented in RPC docs. `listbanned` would probably need to return that for this to work. Right now it'll just use 0 and not link to anything.
👀 1
duke commented 2 years ago
Owner

I will work on making listbanned return this data. Our internals forked from a version of BTC core that didn't know about ASN's, and then when I added ASN support, some RPC's didn't learn about it, such as listbanned

I will work on making listbanned return this data. Our internals forked from a version of BTC core that didn't know about ASN's, and then when I added ASN support, some RPC's didn't learn about it, such as `listbanned`
fekt commented 2 years ago
Collaborator

Code to handle this is in latest commit but will use 0 for now: 9c1db5ff8b/src/bannedpeerstablemodel.cpp (L63)

Code to handle this is in latest commit but will use 0 for now: https://git.hush.is/hush/SilentDragon/src/commit/9c1db5ff8bc2f08a112fa55d8e4e7129cec0b14d/src/bannedpeerstablemodel.cpp#L63
duke added the
feature
 label 1 year ago
duke commented 1 year ago
Owner

So to clarify, SD knows how to do this now but hushd needs to give it the proper data, instead of 0

So to clarify, SD knows how to do this now but hushd needs to give it the proper data, instead of 0
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
chat
custom_themes
danger
dev
duke
importviewkey
master
no_mining_until_synced
old_duke
onryo
recurring
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes