hush
/
SilentDragon
9
1
Fork 7
Code Issues 75 Pull Requests 1 Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

cosmetic (not functional) issue regarding Dark & Midnight themes #101

Open
opened 2 years ago by jahway603 · 5 comments
jahway603 commented 2 years ago
Collaborator

When testing each tab with the Dark and the Midnight themes, it is noticable that the Midnight theme has larger width and height to its tabs and to its button sizes.

When testing each tab with the Dark and the Midnight themes, it is noticable that the Midnight theme has larger width and height to its tabs and to its button sizes.
👀 1
jahway603 changed title from (cosmetic) not functional issue regarding Dark & Midnight themes to cosmetic (not functional) issue regarding Dark & Midnight themes 2 years ago
duke commented 2 years ago
Owner

it's probably a good idea to keep the size of things uniform across different themes. My guess is that there is a different font size in some themes

it's probably a good idea to keep the size of things uniform across different themes. My guess is that there is a different font size in some themes
fekt commented 2 years ago
Collaborator

I noticed this too. The Midnight theme uses larger fonts and I think changes size of inputs too. It is more noticeable on Windows than Linux. I haven't really tested the Blue theme but that has entirely different CSS than other themes too. It'd probably be best to use the same template for all themes and just change the colors to keep things uniform.

I noticed this too. The Midnight theme uses larger fonts and I think changes size of inputs too. It is more noticeable on Windows than Linux. I haven't really tested the Blue theme but that has entirely different CSS than other themes too. It'd probably be best to use the same template for all themes and just change the colors to keep things uniform.
duke commented 2 years ago
Owner

@fekt yeah, I agree. I think the Blue theme was the very first theme, then dark, then midnight, and we didn't do QA on all the the styles to make sure they were uniform

@fekt yeah, I agree. I think the Blue theme was the very first theme, then dark, then midnight, and we didn't do QA on all the the styles to make sure they were uniform
fekt commented 2 years ago
Collaborator

I commented out some stuff in Midnight in latest commit to dev branch that I think should fix some things when comparing to Dark. Need to test on Windows.

I commented out some stuff in Midnight in latest commit to dev branch that I think should fix some things when comparing to Dark. Need to test on Windows.
👍 1
duke commented 1 year ago
Owner

@jahway603 @fekt can we close this or does it need more work?

@jahway603 @fekt can we close this or does it need more work?
duke added the
low priority
bug
 labels 1 year ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
chat
custom_themes
danger
dev
duke
importviewkey
master
no_mining_until_synced
old_duke
onryo
recurring
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes