No Branch/Tag Specified
chat
custom_themes
danger
dev
duke
importviewkey
master
no_mining_until_synced
old_duke
onryo
recurring
0.4.0
0.4.1
0.4.2
0.4.3
0.5.0
0.5.1
0.5.10
0.5.11
0.5.3
0.5.4
0.5.5
0.6.0
0.6.1
0.6.10
0.6.11
0.6.2
0.6.3
0.6.4
0.6.5
0.6.6
0.6.7
0.6.8
0.6.9
0.7.0
0.7.1
0.7.2
0.7.3
0.7.4
0.7.5
0.7.6
0.7.7
0.7.9
1.4.2
v0.1.5
v0.1.6
v0.1.7
v0.1.8
v0.1.9
v0.2.0
v0.2.1
v0.2.2
v0.2.3
v0.2.4
v0.2.5
v0.2.6
v0.2.7
v0.2.8
v0.2.9
v0.3.0
v0.3.1
v0.3.2
v0.5.2
v0.5.6
v0.5.7
v0.5.8
v0.5.9
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.1
v0.8.2
v0.8.3
v0.9.0
v0.9.1
v0.9.2
v1.0.0
v1.1.0
v1.2.0
v1.3.0
v1.3.1
v1.4.0
v1.4.1
v1.4.2
Labels
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label
0-500 bounty
2001-5000 bounty
501-2000 bounty
arm
beginners
bug
build
documentation
feature
high priority
i2p
low priority
medium priority
question
release
tor
translation
windows
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
This issue currently doesn't have any dependencies.
Reference in new issue
There is no content yet.
Delete Branch '%!s(MISSING)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
I did not notice this until now due to user reporting issue because I created wallet and synced with hushd from terminal initially. On a completely fresh install, SD opens up this popup and then crashes when clicking OK. Trying to open again crashes again with same
Performing wallet upgrade to 60000
in debug.log. If you start hushd manually and then open SD, it works fine. Not sure if there is some Mac specific code causing this issue or possibly an issue with the .dmg and packaged bins, but needs further testing.debug.log
SilentDragon.log
Seems it's just not starting hushd.
Something weird with it trying to run bundled in .app on a fresh install. If there is data in HUSH3 directory after it crashes, running hushd from terminal gives this seg fault. This crash happens whether running hushd manually from bundled .app location or seperate binaries in own location. If I delete all data, I can start hushd fine from .app bundled location. I can then kill hushd in terminal and open SD fine and it runs bundled hushd fine. Seems like something with initial data creation that causes it to crash.
Left is running SD (crashes). Right is starting hushd in silentdragon.app from terminal (works).
https://www.diffchecker.com/SXi3Incu/
Stack trace:
It seems the underlying issue is consolidation=1 in HUSH3.conf. If I remove it then it starts fine from SD. The auto-generated config file is adding it by default. If I close SD and add it back, SD still opens up fine.
@fekt sounds weird. If you want to change the code to not add in
consolidation=1
for Macs, that sounds fine.I tested adding an ifndef to only add consolidation=1 if not Mac and it works. I then tested on a fresh install on Linux and the same crash happens with consolidation=1 so it doesn't appear to be Mac specific and affects all fresh SD installs with no existing HUSH data.
It was added 2 years ago here:
12571798f0
Maybe related to other recent changes with consolidation and sweeping or just nobody noticed this bug? I've never actually seen that config popup before because I've only installed SD after already using hushd from cli.
@fekt I am pretty sure this code once worked, but it looks like maybe having
consolidation=1
turned on with an initial sync no longer works, such as when SD creates HUSH3.conf . Are you able to show a backtrace of the coredump from Linux?@fekt I was close to making a new SD release but it sounds like we should try to fix this bug before that. Let me know how I can help.
Linux stack traces.
This one is for hushd
This is for silentdragon
On SD startup, it logs this:
It seems to find hushd, says it's started, and then says it couldn't start and crashes.
@fekt I ran into a coredump while working on randomx that I think is actually the same issue causing this. Try the latest commit in the hush3 dev branch and see if this still happens. The code was calling
pindex->GetHeight()
butpindex
was NULL.Still get a crash on Mac, but it wasn't showing me stack trace and need to get one. No crash on Linux now but instead I get authenication failed. If there is no existing HUSH3.conf, SD creates one with really short user/pass like attached. Not sure if there is a check in SD for length or something that thinks it's invalid.
Crashes here: https://git.hush.is/hush/hush3/src/branch/dev/src/init.cpp#L2045
It has a value for pwalletMain->consolidationInterval. chainActive.Tip()->GetHeight() crashes.
Actually I do still get a crash for hushd on Linux too. It just wasn't causing SD to crash now. I think the easiest way to reproduce is to move or delete all data except for HUSH3.conf, add consolidation=1, and then run hushd from cli. I don't seem to get this crash in 1.3.0 so may only be related to changes in dev branches.
Easiest temp fix might be to not add consolidation=1 in SD at all. If you create fresh wallet with hushd from command line, it does not add consolidation=1.
Default HUSH3.conf created by hushd
Default HUSH3.conf created by SD
@fekt I believe my latest commit to hush3
dev
branch will fix this@duke Yes chainActive.Height() works. I tested same change last night but wasn't sure if it would break anything for when consolidation and sweep runs. I think it set interval to every 24 blocks by default becauses chainActive.Height() returns -1 on fresh install but will test again and check if consolidation/sweep runs.
@duke I figured it was better to have a slightly off nextSweep/nextConsolidation height than coredumping. The first time things run, that value will be updated with a correct value, I think
It does use 24 but I don't think it's a big deal. Anything better than a crash. It is still syncing from scratch. If I restart SD, then
set nextConsolidation=
shows what looks like the height it's currently synced at + interval so I think it's fine.this seems to be fixed, closing