hush
/
SilentDragon
9
1
Fork 7
Code Issues 73 Pull Requests 1 Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

Transaction tab only showing 10 transactions (SDX) #126

Closed
opened 1 year ago by duke · 5 comments
duke commented 1 year ago
Owner

This happened on Windows 10 Home 64bit SDX v1.3.1

This happened on Windows 10 Home 64bit SDX v1.3.1
duke commented 1 year ago
Poster
Owner

This seems related to the fact that it was showing 10 tx's of type "Generated". When the user does other types of tx's, those show up and they now report seeing 13 tx's on that Transaction tab. We may have a bug where only the last 10 tx's of type "generated" are shown, in both SD+SDX

This seems related to the fact that it was showing 10 tx's of type "Generated". When the user does other types of tx's, those show up and they now report seeing 13 tx's on that Transaction tab. We may have a bug where only the last 10 tx's of type "generated" are shown, in both SD+SDX
duke commented 1 year ago
Poster
Owner

SD/SDX uses "listtransactions" RPC with no arguments, which defaults to only showing the last 10 transactions. Shielded transactions use a different RPC, so it will show all ztx's. This bug is only related to transparent tx's, and since sending to a taddr is not allowed on DragonX or HUSH, this bug only affects mining tx's.

We need use "listtransactions" with non-default arguments in src/rpc.cpp. We want to emulate something like listtransactions "*" 99999 instead of just listtransactions. A better long term change is to use the getalldata RPC but that is a bigger change to SD internals

SD/SDX uses "listtransactions" RPC with no arguments, which defaults to only showing the last 10 transactions. Shielded transactions use a different RPC, so it will show all ztx's. This bug is only related to transparent tx's, and since sending to a taddr is not allowed on DragonX or HUSH, this bug only affects mining tx's. We need use "listtransactions" with non-default arguments in src/rpc.cpp. We want to emulate something like `listtransactions "*" 99999` instead of just `listtransactions`. A better long term change is to use the `getalldata` RPC but that is a bigger change to SD internals
👀 1
duke added the
high priority
bug
 labels 1 year ago
duke added the
beginners
 label 11 months ago
duke commented 11 months ago
Poster
Owner

This is a simple fix that is a good "beginner" issue to work on, @dan_s do you have any interest in working on this, since it mostly affects DragonX users?

This is a simple fix that is a good "beginner" issue to work on, @dan_s do you have any interest in working on this, since it mostly affects DragonX users?
fekt commented 10 months ago
Collaborator

This should be fixed now in dev branch with dbc34dde12

I am seeing more than 10 "generate" transactions now for mining rewards but others can test.

This should be fixed now in `dev` branch with https://git.hush.is/hush/SilentDragon/commit/dbc34dde12181b65e81d1382f6924b0ec63b9aeb I am seeing more than 10 "generate" transactions now for mining rewards but others can test.
👍 1
duke commented 9 months ago
Poster
Owner

Calling this fixed, closing

Calling this fixed, closing
duke closed this issue 9 months ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
chat
custom_themes
danger
dev
duke
importviewkey
master
no_mining_until_synced
old_duke
onryo
recurring
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes