Invalid file name/path when exporting txs or backing up wallet on Windows #128

This may be a Windows only bug in SD and SDX. I noticed it when exporting transactions from File > Export transactions. User reported the same when File > Backup wallet.dat

It seems to be creating a file name with a path and the "/" is invalid in the name. The file name should only be output once and path is not needed.

photo_2023-03-18_09-36-42.jpg

12 KiB

This is a very old windows-specific bug, not sure what is going on:

https://github.com/MyHush/SilentDragon/issues/35

Looks like getSaveFileURL is being called incorrectly:
https://doc.qt.io/qt-5/qfiledialog.html#getSaveFileUrl

QString exportName = "hush-transactions-" + QDateTime::currentDateTime().toString("yyyyMMdd") + ".csv";

QUrl csvName = QFileDialog::getSaveFileUrl(this,
        tr("Export transactions"), exportName, "CSV file (*.csv)");

Should be able to fix similar to this:
https://stackoverflow.com/questions/60469292/qt-getsavefileurl-method-duplicating-default-file-name

I'll test when I can unless someone else gets to it first.

Fixed now in dev branch and added support for dragonx file names.

drgx-save.PNG

29 KiB

@fekt have you tested this on Linux ? The weird thing about this bug is that it worked on Linux + Mac, iirc

@duke I tested on Mac and it was working there. Mac wasn't displaying any file name at all and made you type it in though. Does the filename show on Linux?

@fekt looks good on Linux