View transaction #136

Open
opened 5 months ago by duke · 7 comments
duke commented 5 months ago
Owner

Similar to "View Block" it would be ideal to also have "View transaction" so users can basically verify anything they see on an explorer with their local node. This code will need to be slightly different than "View Block" because different data is known about a tx depending on if we were the sender, receiver or not involved in it and also if it was a coinbase tx, t2z, t2t, or z2z.

Similar to "View Block" it would be ideal to also have "View transaction" so users can basically verify anything they see on an explorer with their local node. This code will need to be slightly different than "View Block" because different data is known about a tx depending on if we were the sender, receiver or not involved in it and also if it was a coinbase tx, t2z, t2t, or z2z.
duke added the
feature
label 5 months ago
Poster
Owner

The RPCs that we will need to talk to work on this include getrawtransaction and z_viewtransaction which need to be added to SD.

The RPCs that we will need to talk to work on this include `getrawtransaction` and `z_viewtransaction` which need to be added to SD.
Poster
Owner

RPC method for z_viewtransaction has been added to the dev branch

RPC method for `z_viewtransaction` has been added to the dev branch
Poster
Owner

getrawtransaction is on dev now as well

`getrawtransaction` is on dev now as well
Poster
Owner

Currently we only use getrawtransaction RPC but I tested z_viewtransaction and it did work. We now have a basic implementation of this on the dev branch. It needs some tweaks to render more of the data, for instance it doesn't render any of the data in the arrays of transparent inputs/outputs and shielded inputs/outputs. There is also a bug where valueBalance is being treated as a double instead of a string and it being incorrectly rounded.

Currently we only use `getrawtransaction` RPC but I tested `z_viewtransaction` and it did work. We now have a basic implementation of this on the `dev` branch. It needs some tweaks to render more of the data, for instance it doesn't render any of the data in the arrays of transparent inputs/outputs and shielded inputs/outputs. There is also a bug where `valueBalance` is being treated as a double instead of a string and it being incorrectly rounded.
Poster
Owner

The most intuitive UI for this is for a user to right click on a tx in their Transactions tab and choose "View Transaction". That needs to be added, which will require refactoring the code. Currently the code assumes a popup window is needed to ask for a txid, but the above UI already knows the txid and just renders the data

The most intuitive UI for this is for a user to right click on a tx in their Transactions tab and choose "View Transaction". That needs to be added, which will require refactoring the code. Currently the code assumes a popup window is needed to ask for a txid, but the above UI already knows the txid and just renders the data
Poster
Owner

Right click menu option was added. Also, current behavior is that double clicking on a tx in the tx tab allows a user to reply to a memo in that tx, if it exists, otherwise double clicking does nothing. Now, if there is no memo, double clicking on a tx will show the View Transaction popup.

Currently rendering transparent inputs and shielded outputs is implemented.

Right click menu option was added. Also, current behavior is that double clicking on a tx in the tx tab allows a user to reply to a memo in that tx, if it exists, otherwise double clicking does nothing. Now, if there is no memo, double clicking on a tx will show the View Transaction popup. Currently rendering transparent inputs and shielded outputs is implemented.
Poster
Owner

Things that still need to be rendered:

  • Shielded inputs
  • Transparent outputs (less important)
Things that still need to be rendered: * [ ] Shielded inputs * [ ] Transparent outputs (less important)
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.