Labels Milestones

New Issue

Import dialog shows up even with entered incorrect privkey #142

Closed

opened 4 months ago by onryo · 4 comments

onryo commented 4 months ago

Collaborator

https://git.hush.is/hush/SilentDragon/src/branch/dev/src/mainwindow.cpp#L1289

 https://git.hush.is/hush/SilentDragon/src/branch/dev/src/mainwindow.cpp#L1289

image.png

37 KiB

👍 1

onryo added the

bug

label 4 months ago

duke commented 4 months ago

Owner

Also "it may take several minutes" is a severe underestimate , we should probably change that text.

Also "it may take several minutes" is a severe underestimate , we should probably change that text.

onryo added the

beginners

label 4 months ago

onryo self-assigned this 4 months ago

duke commented 4 months ago

Owner

@onryo what incorrect privkey did you use to find this bug? It would be good to have a test case.

This bug seems to be caused because doImport returns void, so the code that calls it doesn't know when it fails. Also, the private keys are not validated to look reasonable before calling doImport . We have a function isValidSaplingPrivateKey() we can use but we need a similar function for taddr privkeys.

@onryo what incorrect privkey did you use to find this bug? It would be good to have a test case. This bug seems to be caused because `doImport` returns void, so the code that calls it doesn't know when it fails. Also, the private keys are not validated to look reasonable before calling `doImport` . We have a function `isValidSaplingPrivateKey()` we can use but we need a similar function for taddr privkeys.

duke commented 4 months ago

Owner

I just pushed a commit to the branch that implements a isValidTransparentPrivateKey function (not perfect but better than nothing), which is not used anywhere yet. We should be able to use it, along with isValidSaplingPrivateKey to filter out invalid privkeys from being imported and avoid this bug.

I just pushed a commit to the branch that implements a `isValidTransparentPrivateKey` function (not perfect but better than nothing), which is not used anywhere yet. We should be able to use it, along with `isValidSaplingPrivateKey` to filter out invalid privkeys from being imported and avoid this bug.

👀 1

duke commented 4 months ago

Owner

Since the import branch was merged to dev we now validate private keys for taddrs/zaddr much more strictly, so I am considering this bug fixed

Since the `import` branch was merged to `dev` we now validate private keys for taddrs/zaddr much more strictly, so I am considering this bug fixed

👍 1

duke closed this issue 4 months ago

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

chat

custom_themes

danger

dev

duke

importviewkey

master

no_mining_until_synced

old_duke

onryo

recurring

0.4.0

0.4.1

0.4.2

0.4.3

0.5.0

0.5.1

0.5.10

0.5.11

0.5.3

0.5.4

0.5.5

0.6.0

0.6.1

0.6.10

0.6.11

0.6.2

0.6.3

0.6.4

0.6.5

0.6.6

0.6.7

0.6.8

0.6.9

0.7.0

0.7.1

0.7.2

0.7.3

0.7.4

0.7.5

0.7.6

0.7.7

0.7.9

1.4.2

v0.1.5

v0.1.6

v0.1.7

v0.1.8

v0.1.9

v0.2.0

v0.2.1

v0.2.2

v0.2.3

v0.2.4

v0.2.5

v0.2.6

v0.2.7

v0.2.8

v0.2.9

v0.3.0

v0.3.1

v0.3.2

v0.5.2

v0.5.6

v0.5.7

v0.5.8

v0.5.9

v0.7.5

v0.7.6

v0.7.7

v0.7.8

v0.8.0

v0.8.1

v0.8.2

v0.8.3

v0.9.0

v0.9.1

v0.9.2

v1.0.0

v1.1.0

v1.2.0

v1.3.0

v1.3.1

v1.4.0

v1.4.1

v1.4.2

Labels

Apply labels

Clear labels

0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed

No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

onryo

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.