Command `./build.sh release` does not work for SD 1.4.2
Describe the bug
When running ./build.sh release on SD 1.4.2, it will not build anymore. Successfully tested that this works fine on the previous version, SD 1.4.1.
To Reproduce
Steps to reproduce the behavior:
Download SD 1.4.2 source code and extract.
Run ./build.sh linguist
Run ./build.sh release
See following error:
$ ./build.sh release
Compiling SilentDragon 1.4.2 with threads...
QMake version 3.1
Using Qt version 5.15.12 in /usr/lib
GNU Make 4.4.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Makefile:2475: warning: overriding recipe for target 'src/ui_viewalladdresses.h'
Makefile:2467: warning: ignoring old recipe for target 'src/ui_viewalladdresses.h'
Makefile:2487: warning: overriding recipe for target 'src/ui_viewalladdresses.h'
Makefile:2475: warning: ignoring old recipe for target 'src/ui_viewalladdresses.h'
make: *** No rule to make target 'release'. Stop.
Expected behavior
For it to successfully build as it did in the previous release.
Desktop (please complete the following information):
OS: This failed on both Artix and Arch Linux
Additional context
The command ./build.sh release worked fine on the previous version, SD 1.4.1.
---
name: Bug report
about:
title: 'Command `./build.sh release` does not work for SD 1.4.2'
labels: ''
assignees: ''
---
**Describe the bug**
When running `./build.sh release` on SD 1.4.2, it will not build anymore. Successfully tested that this works fine on the previous version, SD 1.4.1.
**To Reproduce**
Steps to reproduce the behavior:
1. Download SD 1.4.2 source code and extract.
1. Run `./build.sh linguist`
1. Run `./build.sh release`
1. See following error:
```
$ ./build.sh release
Compiling SilentDragon 1.4.2 with threads...
QMake version 3.1
Using Qt version 5.15.12 in /usr/lib
GNU Make 4.4.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Makefile:2475: warning: overriding recipe for target 'src/ui_viewalladdresses.h'
Makefile:2467: warning: ignoring old recipe for target 'src/ui_viewalladdresses.h'
Makefile:2487: warning: overriding recipe for target 'src/ui_viewalladdresses.h'
Makefile:2475: warning: ignoring old recipe for target 'src/ui_viewalladdresses.h'
make: *** No rule to make target 'release'. Stop.
```
**Expected behavior**
For it to successfully build as it did in the previous release.
**Desktop (please complete the following information):**
- OS: This failed on both Artix and Arch Linux
**Additional context**
The command `./build.sh release` worked fine on the previous version, SD 1.4.1.
yeah, it looks like when build.sh learned to take arguments of number of jobs to compile with, it broke it. It ends up trying to run make release which is a Makefile target that doesn't exist
yeah, it looks like when `build.sh` learned to take arguments of number of jobs to compile with, it broke it. It ends up trying to run `make release` which is a Makefile target that doesn't exist
Describe the bug
When running
./build.sh release
on SD 1.4.2, it will not build anymore. Successfully tested that this works fine on the previous version, SD 1.4.1.To Reproduce
Steps to reproduce the behavior:
./build.sh linguist
./build.sh release
Expected behavior
For it to successfully build as it did in the previous release.
Desktop (please complete the following information):
Additional context
The command
./build.sh release
worked fine on the previous version, SD 1.4.1.yeah, it looks like when
build.sh
learned to take arguments of number of jobs to compile with, it broke it. It ends up trying to runmake release
which is a Makefile target that doesn't exist