Placeholder image in balances tab #39

Open
opened 3 years ago by duke · 6 comments
duke commented 3 years ago
Owner

When there are many addresses and utxos, this screen is blank for many seconds before final data is rendered

When there are many addresses and utxos, this screen is blank for many seconds before final data is rendered
Collaborator

I noticed this issue too

I noticed this issue too
Collaborator

For me it shows this "Loading..." text in balance and amount columns.
https://git.hush.is/hush/SilentDragon/src/branch/dev/src/balancestablemodel.cpp#L65

I'm not sure exactly what else can be done with it being a QTableView. Similar to #97 but that table doesn't have this functionality.

There is also different behavior if you close the splash screen while hushd starting and waiting for a connection still.

For me it shows this "Loading..." text in balance and amount columns. https://git.hush.is/hush/SilentDragon/src/branch/dev/src/balancestablemodel.cpp#L65 I'm not sure exactly what else can be done with it being a QTableView. Similar to https://git.hush.is/hush/SilentDragon/issues/97 but that table doesn't have this functionality. There is also different behavior if you close the splash screen while hushd starting and waiting for a connection still.
Poster
Owner

@fekt you are talking about the Balance tab, which does show "Loading...". The "Transactions" tab is completely blank before any data loads.

@fekt you are talking about the Balance tab, which does show "Loading...". The "Transactions" tab is completely blank before any data loads.
Collaborator

@duke Yeah, I was just saying for this issue related to balances tab, it shows "Loading..." for me so I wasn't sure if this was still an issue.

The transaction tab in #97 does not have a loading check. I added one similar to what the balances tab does to see if that works, but need to test with loading an old wallet.

I was seeing some functionality where I think transactions get stored in QSettings and then the table tries to load those first kind of like a cache. For me, it is always loading test memos I sent as initial data from these settings before loading all txs. If there is nothing in settings then transactions tab will probably show nothing initially.

@duke Yeah, I was just saying for this issue related to balances tab, it shows "Loading..." for me so I wasn't sure if this was still an issue. The transaction tab in #97 does not have a loading check. I added one similar to what the balances tab does to see if that works, but need to test with loading an old wallet. I was seeing some functionality where I think transactions get stored in QSettings and then the table tries to load those first kind of like a cache. For me, it is always loading test memos I sent as initial data from these settings before loading all txs. If there is nothing in settings then transactions tab will probably show nothing initially.
Poster
Owner

@fekt yeah, what you are seeing is sent tx's rendered before received tx's, because they are stored in senttxstore.dat and are much faster to load, especially on large wallets. I have a large wallet to test #97 on if you push the code.

Another issue is that when just the sent tx data is loaded, the Transactions tab looks like it's finished loading, but I have seen it take minutes to finally load all the other sent tx's in that tab. We need the "Loading..." text to show until all data has been rendered, sent+received.

@fekt yeah, what you are seeing is sent tx's rendered before received tx's, because they are stored in senttxstore.dat and are much faster to load, especially on large wallets. I have a large wallet to test #97 on if you push the code. Another issue is that when just the sent tx data is loaded, the Transactions tab looks like it's finished loading, but I have seen it take minutes to finally load all the other sent tx's in that tab. We need the "Loading..." text to show until *all* data has been rendered, sent+received.
Poster
Owner

And while we are talking about it, SD needs to start using getalldata RPC, which will make everything faster, since it should be able to get all the data it needs via a single RPC, instead of waiting for multiple RPC's to return

And while we are talking about it, SD needs to start using `getalldata` RPC, which will make everything faster, since it should be able to get all the data it needs via a single RPC, instead of waiting for multiple RPC's to return
duke added the
feature
label 1 year ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.