hush
/
SilentDragon
9
1
Fork 7
Code Issues 73 Pull Requests 1 Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

Generate Mobile QR code earlier in wallet startup #41

Closed
opened 3 years ago by duke · 6 comments
duke commented 3 years ago
Owner

Right now it's possible to startup SD, quickly press CTRL-M for the mobile pairing screen, and be presented with a large blank area instead of a pairing QR code, because the wallet is doing expensive wallet startup stuff and hasn't yet generated a QR code. If the user closes the window, waits for all zxtn data to populate, then does CTRL-M again, the QR code is there.

Simple fix is to move QR-code generation to be before expensive zxtns calls when the wallet starts.

Right now it's possible to startup SD, quickly press CTRL-M for the mobile pairing screen, and be presented with a large blank area instead of a pairing QR code, because the wallet is doing expensive wallet startup stuff and hasn't yet generated a QR code. If the user closes the window, waits for all zxtn data to populate, then does CTRL-M again, the QR code is there. Simple fix is to move QR-code generation to be before expensive zxtns calls when the wallet starts.
fekt commented 2 years ago
Collaborator

@duke Do you know if this is still an issue for you? I just updated size of QR code here to be the same as on the "receive tab" as I missed it previously. While tx data is still loading, I am able to press ctrl+m and see the QR code.

@duke Do you know if this is still an issue for you? I just updated size of QR code here to be the same as on the "receive tab" as I missed it previously. While tx data is still loading, I am able to press ctrl+m and see the QR code.
fekt commented 2 years ago
Collaborator

For me this issue actually happens on the "receive tab" when waiting for txs because it seems to be waiting for an address to use for the QR code.

For me this issue actually happens on the "receive tab" when waiting for txs because it seems to be waiting for an address to use for the QR code.
duke commented 2 years ago
Poster
Owner

@fekt my guess is that this happened to me on a large wallet, where it took over 2 minutes to fill in all transaction history+balances and the bug still exists. We need to reorder QR code generation to be before all RPC's, since it's almost instantaneous.

@fekt my guess is that this happened to me on a large wallet, where it took over 2 minutes to fill in all transaction history+balances and the bug still exists. We need to reorder QR code generation to be before all RPC's, since it's almost instantaneous.
jahway603 commented 1 year ago
Collaborator

This issue only applies when using the old SDA pairing wallet, right?

This issue only applies when using the old SDA pairing wallet, right?
duke commented 1 year ago
Poster
Owner

@jahway603 yes

@jahway603 yes
jahway603 commented 1 year ago
Collaborator

Closing this Issue due to recently opened Issue #116

Closing this Issue due to recently opened Issue https://git.hush.is/hush/SilentDragon/issues/116
jahway603 closed this issue 1 year ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
chat
custom_themes
danger
dev
duke
importviewkey
master
no_mining_until_synced
old_duke
onryo
recurring
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes