The user is left to guess which addresses have unconfirmed funds and which transactions are not confirmed, leaving them to guess which addresses they can use to send funds. Shitty experience.
We could highlight addresses with unconfirmed funds in red, as one option
The user is left to guess which addresses have unconfirmed funds and which transactions are not confirmed, leaving them to guess which addresses they can use to send funds. Shitty experience.
We could highlight addresses with unconfirmed funds in red, as one option
In default and blue themes, addresses and txs are highlighted red. In other themes, the color change may not apply I think because theme's CSS is overriding the change.
In default and blue themes, addresses and txs are highlighted red. In other themes, the color change may not apply I think because theme's CSS is overriding the change.
Balances table: https://git.hush.is/hush/SilentDragon/src/branch/dev/src/balancestablemodel.cpp#L76
Transactions table: https://git.hush.is/hush/SilentDragon/src/branch/dev/src/txtablemodel.cpp#L113
Confirmed this is a theme issue. Any theme that overrides QTableview::item text color will not have color applied in previously mentioned code and use CSS instead. For dark themes, the text will always be white. See this for example: https://git.hush.is/hush/SilentDragon/src/branch/dev/res/css/dark.css#L5
A fix is to remove QTableview::item from being set in CSS. Then have a theme check in code to set black or white text conditionally based on light or dark theme. The red for unconfirmed txs will also take effect then. I have this done but still testing on Linux and Windows.
Can maybe add colors as constants so it's easier to manage and change in the future.
Confirmed this is a theme issue. Any theme that overrides QTableview::item text color will not have color applied in previously mentioned code and use CSS instead. For dark themes, the text will always be white. See this for example: https://git.hush.is/hush/SilentDragon/src/branch/dev/res/css/dark.css#L5
A fix is to remove QTableview::item from being set in CSS. Then have a theme check in code to set black or white text conditionally based on light or dark theme. The red for unconfirmed txs will also take effect then. I have this done but still testing on Linux and Windows.
Can maybe add colors as constants so it's easier to manage and change in the future.
The user is left to guess which addresses have unconfirmed funds and which transactions are not confirmed, leaving them to guess which addresses they can use to send funds. Shitty experience.
We could highlight addresses with unconfirmed funds in red, as one option
In default and blue themes, addresses and txs are highlighted red. In other themes, the color change may not apply I think because theme's CSS is overriding the change.
Balances table: https://git.hush.is/hush/SilentDragon/src/branch/dev/src/balancestablemodel.cpp#L76
Transactions table: https://git.hush.is/hush/SilentDragon/src/branch/dev/src/txtablemodel.cpp#L113
@fekt really good point, I didn't think of that. I was definitely using either the dark or midnight themes when I reported this bug.
Confirmed this is a theme issue. Any theme that overrides QTableview::item text color will not have color applied in previously mentioned code and use CSS instead. For dark themes, the text will always be white. See this for example: https://git.hush.is/hush/SilentDragon/src/branch/dev/res/css/dark.css#L5
A fix is to remove QTableview::item from being set in CSS. Then have a theme check in code to set black or white text conditionally based on light or dark theme. The red for unconfirmed txs will also take effect then. I have this done but still testing on Linux and Windows.
Can maybe add colors as constants so it's easier to manage and change in the future.
@fekt thanks so much for figuring out what the problem was!
I am pretty sure @fekt fixed this, as I used the dark theme and now see red for unconfirmed tx's. Closing