hush
/
SilentDragon
9
1
Fork 7
Code Issues 73 Pull Requests 1 Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

Size of QR Code makes it difficult to scan using a phone #83

Closed
opened 2 years ago by jahway603 · 7 comments
jahway603 commented 2 years ago
Collaborator

When using the Android app to scan the QR Code in SD, the size of the QR code makes it really difficult to scan using a phone.

It needs to render smaller to let the user "futz" less with getting their phone to scan it -- perhaps around 70-80% of its current rendered size.

When using the Android app to scan the QR Code in SD, the size of the QR code makes it really difficult to scan using a phone. It needs to render smaller to let the user "futz" less with getting their phone to scan it -- perhaps around 70-80% of its current rendered size.
fekt commented 2 years ago
Collaborator

This is a simple fix I have finished. I set to a fixed 228x228, which is 3x the recommended minimum size and seems to fit nicely. Trying to see if I can add HUSH logo to the QR code possibly with a stylesheet or some other property that may exist on the object.

This is a simple fix I have finished. I set to a fixed 228x228, which is 3x the recommended minimum size and seems to fit nicely. Trying to see if I can add HUSH logo to the QR code possibly with a stylesheet or some other property that may exist on the object.
👍 1
fekt commented 2 years ago
Collaborator

Fixed here and I also added SD logo to it but could use any image if something else is preferred. e59c0737ea

I am not sure what's up with some of the changes to mainwindow.ui when comitting. Some of the commented out stuff I added back previously and it removed and changed other values again. QT may be doing this automatically when building.

Fixed here and I also added SD logo to it but could use any image if something else is preferred. https://git.hush.is/hush/SilentDragon/commit/e59c0737ea3a24fa2c1e96b9f468154928037195 I am not sure what's up with some of the changes to mainwindow.ui when comitting. Some of the commented out stuff I added back previously and it removed and changed other values again. QT may be doing this automatically when building.
fekt commented 2 years ago
Collaborator

Seeing odd behavior with QR code when testing creating a new taddr. It appears to create the QR code without high ECC for some reason so scanning doesn't work with logo. I was not seeing anything set the ECC differently for a taddr. Maybe something weird with the 3rd party library being used and taddr being a shorter string than zaddr. For zaddr, you'll visibly see difference in QR code appearance with high ECC being used and scanning works fine.

Seeing odd behavior with QR code when testing creating a new taddr. It appears to create the QR code without high ECC for some reason so scanning doesn't work with logo. I was not seeing anything set the ECC differently for a taddr. Maybe something weird with the 3rd party library being used and taddr being a shorter string than zaddr. For zaddr, you'll visibly see difference in QR code appearance with high ECC being used and scanning works fine.
duke commented 2 years ago
Owner

@fekt since there is no way to send to a taddr for normal users, and the only reason to generate a taddr via the GUI is to maybe solo mine to it, I think it's fine if the logo only works with zaddr QR codes

@fekt since there is no way to send to a taddr for normal users, and the only reason to generate a taddr via the GUI is to maybe solo mine to it, I think it's fine if the logo only works with zaddr QR codes
duke commented 2 years ago
Owner

@fekt I also wanted to mention, in case it's relevant: taddrs are case-sensitive (base58) and zaddrs are case-INsensitive (bech32) and QR codes usually have an option for this which makes zaddr QR codes more efficient, since case-insensitive data is more efficient to store in a QR code.

@fekt I also wanted to mention, in case it's relevant: taddrs are case-sensitive (base58) and zaddrs are case-INsensitive (bech32) and QR codes usually have an option for this which makes zaddr QR codes more efficient, since case-insensitive data is more efficient to store in a QR code.
duke commented 2 years ago
Owner

@fekt the new logo in the QR code looks awesome!

@jahway603 do the recent changes fix your concerns?

@fekt the new logo in the QR code looks awesome! @jahway603 do the recent changes fix your concerns?
jahway603 commented 2 years ago
Poster
Collaborator

@fekt thank you for fixing this and the new QR code does look awesome.

@duke yeah, this change fixes this issue.

@fekt thank you for fixing this and the new QR code does look awesome. @duke yeah, this change fixes this issue.
🎉 1
jahway603 closed this issue 2 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
chat
custom_themes
danger
dev
duke
importviewkey
master
no_mining_until_synced
old_duke
onryo
recurring
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes