rescan RPC with optional height #86

Closed
opened 2 years ago by duke · 3 comments
duke commented 2 years ago
Owner

There is a rescan RPC which has never been accessible via SD. Currently SD only supports restarting hushd with the -rescan option. This is slower than calling the RPC.

In the latest dev branch of hush3.git, there is a fix to the rescan RPC which allows it to correctly take an optional height to rescan from. The optional height has always been there but never worked correctly. If you gave an optional height, the RPC would return an error and no rescan would be performed.

This feature will make it very convenient to, for instance, rescan the last 10000 blocks without restarting hushd or having to disable the -rescan option again so it doesn't rescan on every start, which is more work and confusing for users.

There is a `rescan` RPC which has never been accessible via SD. Currently SD only supports restarting hushd with the `-rescan` option. This is slower than calling the RPC. In the latest `dev` branch of hush3.git, there is a fix to the `rescan` RPC which allows it to correctly take an optional height to rescan from. The optional height has always been there but never worked correctly. If you gave an optional height, the RPC would return an error and no rescan would be performed. This feature will make it very convenient to, for instance, rescan the last 10000 blocks without restarting hushd or having to disable the `-rescan` option again so it doesn't rescan on every start, which is more work and confusing for users.
Poster
Owner

the rescan RPC was fixed in hushd 3.9.1, and since most people use SD with it's embedded hushd, this would be a good SD feature to work on. We don't even need to make SD look at the version of hushd being used, as old versions of rescan will immediately return an error if a height is given.

the `rescan` RPC was fixed in hushd 3.9.1, and since most people use SD with it's embedded hushd, this would be a good SD feature to work on. We don't even need to make SD look at the version of hushd being used, as old versions of `rescan` will immediately return an error if a height is given.
Poster
Owner

We now have a method to call the rescan RPC on the dev branch, this still needs a GUI interface to it.

We now have a method to call the rescan RPC on the dev branch, this still needs a GUI interface to it.
Poster
Owner

GUI to rescan now exists and defaults to block height 1 and allows giving an arbitrary height. Closing this

GUI to rescan now exists and defaults to block height 1 and allows giving an arbitrary height. Closing this
duke closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.