Need to think about best way to present clearbanned to unban all banned peers in GUI. Can be a button somewhere or another option in menu when right clicking in banned peer list.
Unbanning single node works here: https://git.hush.is/hush/SilentDragon/commit/a236d833223c52809126c005fbc523edfcf3c9a8
Need to think about best way to present `clearbanned` to unban all banned peers in GUI. Can be a button somewhere or another option in menu when right clicking in banned peer list.
Also wanted to make sure it's OK to be moving these RPCs from private to public in header like this 39a9bf2526. It was telling me they were private when I was trying to call them so I moved to public unless I should be doing things differently. I did same for setban previously.
@duke Unbanning all peers is added here: https://git.hush.is/hush/SilentDragon/commit/186d865b229203b92033e6cf1c811f922fb604d9
Also wanted to make sure it's OK to be moving these RPCs from private to public in header like this https://git.hush.is/hush/SilentDragon/commit/39a9bf2526fed1016da4905574b51225ff08f54f. It was telling me they were private when I was trying to call them so I moved to public unless I should be doing things differently. I did same for setban previously.
Noting that if you ban all peers and then unban all, while refreshPeers is called and lists update, the connected peers list may not show any peers until it actually reconnects to a peer. Similar with banning and unbanning a single peer. They won't show in list until reconnecting to them. This is expected.
Noting that if you ban all peers and then unban all, while `refreshPeers` is called and lists update, the connected peers list may not show any peers until it actually reconnects to a peer. Similar with banning and unbanning a single peer. They won't show in list until reconnecting to them. This is expected.
There is currently no way to unban a single node or unban all nodes via SD, there should be.
We will need methods to call 2 RPC's for this:
clearbannedto remove all banned nodes andsetbanto modify individual bans.We now have a method for
clearbannedon dev, no GUI yetWe now have
setbanmethod on dev, no GUI yetUnbanning single node works here:
a236d83322Need to think about best way to present
clearbannedto unban all banned peers in GUI. Can be a button somewhere or another option in menu when right clicking in banned peer list.@fekt adding a right click option to all banned peers which says "Unban all peers" seems reasonable to me
@duke Unbanning all peers is added here:
186d865b22Also wanted to make sure it's OK to be moving these RPCs from private to public in header like this
39a9bf2526. It was telling me they were private when I was trying to call them so I moved to public unless I should be doing things differently. I did same for setban previously.Noting that if you ban all peers and then unban all, while
refreshPeersis called and lists update, the connected peers list may not show any peers until it actually reconnects to a peer. Similar with banning and unbanning a single peer. They won't show in list until reconnecting to them. This is expected.@fekt yes it's appropriate to move them from private to public. I wasn't using them yet so I didn't put them in the correct place
this works, closing