hush
/
SilentDragon
9
1
Fork 7
Code Issues 73 Pull Requests 1 Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

SilentDragon crashes when right clicking empty banned peers list #95

Closed
opened 2 years ago by fekt · 3 comments
fekt commented 2 years ago
Collaborator

Discovered this when looking at adding GUI functionality for banning/unbanning peers. I have no banned peers currently. Right clicking in empty banned peers list causes SD to crash. Untested behavior when there are banned peers in list.

Discovered this when looking at adding GUI functionality for banning/unbanning peers. I have no banned peers currently. Right clicking in empty banned peers list causes SD to crash. Untested behavior when there are banned peers in list.
😆 1
fekt commented 2 years ago
Poster
Collaborator

Seems to be from referencing wrong table here but not 100% sure:
https://git.hush.is/hush/SilentDragon/src/branch/master/src/mainwindow.cpp#L1215

I changed to bannedPeersTable and no longer crashes. Need to test with banned peers in list.

Seems to be from referencing wrong table here but not 100% sure: https://git.hush.is/hush/SilentDragon/src/branch/master/src/mainwindow.cpp#L1215 I changed to `bannedPeersTable` and no longer crashes. Need to test with banned peers in list.
duke commented 2 years ago
Owner

@fekt yeah that code looks wrong, your edit is probably the correct fix

@fekt yeah that code looks wrong, your edit is probably the correct fix
fekt commented 2 years ago
Poster
Collaborator

Seems fixed in this commit. Tested right clicking in banned peers list with and without peers listed: a236d83322

Seems fixed in this commit. Tested right clicking in banned peers list with and without peers listed: https://git.hush.is/hush/SilentDragon/commit/a236d833223c52809126c005fbc523edfcf3c9a8
👍 1
fekt closed this issue 2 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
chat
custom_themes
danger
dev
duke
importviewkey
master
no_mining_until_synced
old_duke
onryo
recurring
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes