Build error from missing file on dev branch #99

Closed
opened 2 years ago by duke · 7 comments
duke commented 2 years ago
Owner
src/mainwindow.cpp:16:10: fatal error: 'ui_rescandialog.h' file not found
#include "ui_rescandialog.h"
         ^~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [Makefile:2132: bin/mainwindow.o] Error 1
``` src/mainwindow.cpp:16:10: fatal error: 'ui_rescandialog.h' file not found #include "ui_rescandialog.h" ^~~~~~~~~~~~~~~~~~~ 1 error generated. make: *** [Makefile:2132: bin/mainwindow.o] Error 1 ```
fekt was assigned by duke 2 years ago
Poster
Owner

@fekt looks like this file needs to be added to git

@fekt looks like this file needs to be added to git
Collaborator

@duke I will add later tonight. I was working on this on a different machine and version control isn't configured correctly in QT to automatically add files. I was manually adding them when comitting and must have missed this.

@duke I will add later tonight. I was working on this on a different machine and version control isn't configured correctly in QT to automatically add files. I was manually adding them when comitting and must have missed this.
Collaborator

@duke Actually this should be auto-generated during build from src/rescandialog.ui and I think I need to commit siletndragon.pro instead as that added it to forms.

@duke Actually this should be auto-generated during build from src/rescandialog.ui and I think I need to commit siletndragon.pro instead as that added it to forms.
Poster
Owner

@fekt yeah, you might need to add a file rescandialog.ui which is used to generate this c++ header file

@fekt yeah, you might need to add a file `rescandialog.ui` which is used to generate this c++ header file
Collaborator

@duke rescandialog.ui was already there but i modified and comitted again anyway. silentdragon.pro wasn't. i wasn't sure if that was a file that should be ignored. i think it should be good now but let me know if you still get build errors.

should i commit .ts and .qm translation files too? i was ignoring those.

@duke `rescandialog.ui` was already there but i modified and comitted again anyway. `silentdragon.pro` wasn't. i wasn't sure if that was a file that should be ignored. i think it should be good now but let me know if you still get build errors. should i commit .ts and .qm translation files too? i was ignoring those.
Poster
Owner

@fekt .ts files are "translation source" files and .qm files are generated binary files of the *.ts data. They can often change, if you change literal strings in source code and/or run build.sh linguist . My policy is to only update .qm files just before a release, since if multiple devs change those files, dealing with conflicts can be really annoying. If you are actually updating strings in a .ts file, commiting the result is fine, but otherwise, it's fine to ignore them.

@fekt .ts files are "translation source" files and .qm files are generated binary files of the `*.ts` data. They can often change, if you change literal strings in source code and/or run `build.sh linguist` . My policy is to only update .qm files just before a release, since if multiple devs change those files, dealing with conflicts can be really annoying. If you are actually updating strings in a .ts file, commiting the result is fine, but otherwise, it's fine to ignore them.
Poster
Owner

works now, closing this

works now, closing this
duke closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.