@duke do we have good reproducible build steps for the [f-droid approach](https://git.hush.is/jahway603/sda-fdroid/issues/4) or shall we continue hosting our own [unofficial f-droid repo](https://git.hush.is/jahway603/sda-fdroid)?
@jahway603 I don't know exactly what "f-droid approach" means, we should probably continue doing the unofficial repo approach, since that is better than nothing.
@jahway603 I don't know exactly what "f-droid approach" means, we should probably continue doing the unofficial repo approach, since that is better than nothing.
@fekt would know more about building the app
From what I reviewed quickly, they would need a fork of the code on GitLab or other supported platform. They build the code from source. Maybe Gitea works, I don't know. One main issue with that is the dependency for the SDK currently relies on publishToMavenLocal. Their build will likely fail due to that. At minimum, the SDK would need to get published somewhere for it to not rely on a local build. Jitpack does not work as they don't seem to compile Rust and their builds fail for missing rustc. It would likely need to be published to actual Maven repo, but I'm not familiar with that either. There is or was some existing config for that, but it's for Zcash and would need to be modified.
There are potentially other dependencies Zcash has included in the app that may violate being listed on F-Droid too and would need to be reviewed. I don't think anything is functionality breaking. I know I saw some stuff for reporting that may need to be removed entirely but may only be in test or darkside builds. There is a decent amount of unused code that could be cleaned up at some point related to Zcash-specific functionality for auto-shielding, transparent funds, Orchard, etc.
I am not familiar with publishing to F-Droid. There are a couple of guides for reference:
https://f-droid.org/docs/Submitting_to_F-Droid_Quick_Start_Guide
https://kaeruct.github.io/posts/publishing-an-app-on-f-droid.html
From what I reviewed quickly, they would need a fork of the code on GitLab or other supported platform. They build the code from source. Maybe Gitea works, I don't know. One main issue with that is the dependency for the SDK currently relies on publishToMavenLocal. Their build will likely fail due to that. At minimum, the SDK would need to get published somewhere for it to not rely on a local build. Jitpack does not work as they don't seem to compile Rust and their builds fail for missing rustc. It would likely need to be published to actual Maven repo, but I'm not familiar with that either. There is or was some existing config for that, but it's for Zcash and would need to be modified.
There are potentially other dependencies Zcash has included in the app that may violate being listed on F-Droid too and would need to be reviewed. I don't think anything is functionality breaking. I know I saw some stuff for reporting that may need to be removed entirely but may only be in test or darkside builds. There is a decent amount of unused code that could be cleaned up at some point related to Zcash-specific functionality for auto-shielding, transparent funds, Orchard, etc.
yep
@duke do we have good reproducible build steps for the f-droid approach or shall we continue hosting our own unofficial f-droid repo?
@jahway603 I don't know exactly what "f-droid approach" means, we should probably continue doing the unofficial repo approach, since that is better than nothing.
@fekt would know more about building the app
I am not familiar with publishing to F-Droid. There are a couple of guides for reference:
https://f-droid.org/docs/Submitting_to_F-Droid_Quick_Start_Guide
https://kaeruct.github.io/posts/publishing-an-app-on-f-droid.html
From what I reviewed quickly, they would need a fork of the code on GitLab or other supported platform. They build the code from source. Maybe Gitea works, I don't know. One main issue with that is the dependency for the SDK currently relies on publishToMavenLocal. Their build will likely fail due to that. At minimum, the SDK would need to get published somewhere for it to not rely on a local build. Jitpack does not work as they don't seem to compile Rust and their builds fail for missing rustc. It would likely need to be published to actual Maven repo, but I'm not familiar with that either. There is or was some existing config for that, but it's for Zcash and would need to be modified.
There are potentially other dependencies Zcash has included in the app that may violate being listed on F-Droid too and would need to be reviewed. I don't think anything is functionality breaking. I know I saw some stuff for reporting that may need to be removed entirely but may only be in test or darkside builds. There is a decent amount of unused code that could be cleaned up at some point related to Zcash-specific functionality for auto-shielding, transparent funds, Orchard, etc.