Labels Milestones

New Issue

Wormhole continues parsing input after emitting an error #6

Open

opened 2 years ago by jahway603 · 2 comments

jahway603 commented 2 years ago

Collaborator

Ported from issue #3 on GitHub

TOB-ZEC-018 from https://github.com/trailofbits/publications/blob/master/reviews/zecwallet.pdf

Add a return to prevent parsing invalid data when message is too large

Ported from [issue #3 on GitHub](https://github.com/MyHush/SilentDragonWormhole/issues/3) TOB-ZEC-018 from https://github.com/trailofbits/publications/blob/master/reviews/zecwallet.pdf Add a `return` to prevent parsing invalid data when message is too large

jahway603 commented 2 years ago

Poster

Collaborator

I just read this and is this issue to just add return to end of sendError() ?

I just read this and is this issue to just add return to end of [sendError()](https://git.hush.is/hush/SilentDragonWormhole/src/branch/master/src/main/kotlin/com/silentdragon/wormhole/Service.kt#L105) ?

duke commented 2 years ago

Owner

@jahway603 I think so? I am not sure.

@jahway603 I think so? I am not sure.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

dev

master

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.