hush
/
explorer.hush.is
forked from duke/explorer.hush.is
8
0
Fork 0
Code Issues 8 Pull Requests Projects Releases Wiki Activity
Labels Milestones
New Issue

Rendering tx's in a block bugs #6

Open
opened 2 years ago by duke · 0 comments
duke commented 2 years ago
Owner

From #5 @onryo mentioned

https://explorer.hush.is/block/822350
https://explorer.hush.land/block/822350

There is a bug that I will explain. The 2nd tx in that block, 573... says vins: 2, vouts: 0 which means 2 taddr inputs and 0 zaddr outputs. But the HTML renders

RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => RDXuRCaCVEY9C6A9Y8P9DS2PgxaJZSAoZN
RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn =>

when it should render

RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => 
RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn =>

since there are no taddr ouputs. The code has a bug where it still has RDXuRCaCVEY9C6A9Y8P9DS2PgxaJZSAoZN saved as an output from the first tx, and those outputs should be deleted when rendering data for the next tx. Should be a small and simple fix.

Also, while we are at it, I think we should be more clear about zaddr outputs, and render it as:

RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => ?
RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => ?

OR

RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => z
RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => z

to make it clear that it's a private transaction where the outputs are not publicly known.

From #5 @onryo mentioned https://explorer.hush.is/block/822350 https://explorer.hush.land/block/822350 There is a bug that I will explain. The 2nd tx in that block, 573... says `vins: 2, vouts: 0` which means 2 taddr inputs and 0 zaddr outputs. But the HTML renders ``` RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => RDXuRCaCVEY9C6A9Y8P9DS2PgxaJZSAoZN RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => ``` when it should render ``` RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => ``` since there are no taddr ouputs. The code has a bug where it still has RDXuRCaCVEY9C6A9Y8P9DS2PgxaJZSAoZN saved as an output from the first tx, and those outputs should be deleted when rendering data for the next tx. Should be a small and simple fix. Also, while we are at it, I think we should be more clear about zaddr outputs, and render it as: ``` RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => ? RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => ? ``` OR ``` RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => z RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn => z ``` to make it clear that it's a private transaction where the outputs are not publicly known.
👀 1
onryo self-assigned this 2 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
onryo
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes