From 192cc910ec7cade1d0dce7f3b111e7fc7720e607 Mon Sep 17 00:00:00 2001 From: Matt Corallo Date: Fri, 18 Jan 2013 13:55:18 -0500 Subject: [PATCH] Replace 520 constant with MAX_SCRIPT_ELEMENT_SIZE --- src/main.cpp | 2 +- src/script.cpp | 4 ++-- src/script.h | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index 9fa6ebf24..4febf332d 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -3588,7 +3588,7 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv) // Nodes must NEVER send a data item > 520 bytes (the max size for a script data object, // and thus, the maximum size any matched object can have) in a filteradd message - if (vData.size() > 520) + if (vData.size() > MAX_SCRIPT_ELEMENT_SIZE) { pfrom->Misbehaving(100); } else { diff --git a/src/script.cpp b/src/script.cpp index 70adf1f9d..45ac8335d 100644 --- a/src/script.cpp +++ b/src/script.cpp @@ -340,7 +340,7 @@ bool EvalScript(vector >& stack, const CScript& script, co // if (!script.GetOp(pc, opcode, vchPushValue)) return false; - if (vchPushValue.size() > 520) + if (vchPushValue.size() > MAX_SCRIPT_ELEMENT_SIZE) return false; if (opcode > OP_16 && ++nOpCount > 201) return false; @@ -670,7 +670,7 @@ bool EvalScript(vector >& stack, const CScript& script, co valtype& vch2 = stacktop(-1); vch1.insert(vch1.end(), vch2.begin(), vch2.end()); popstack(stack); - if (stacktop(-1).size() > 520) + if (stacktop(-1).size() > MAX_SCRIPT_ELEMENT_SIZE) return false; } break; diff --git a/src/script.h b/src/script.h index 0b481eb60..4b29f6273 100644 --- a/src/script.h +++ b/src/script.h @@ -17,6 +17,8 @@ class CCoins; class CTransaction; +static const unsigned int MAX_SCRIPT_ELEMENT_SIZE = 520; // bytes + /** Signature hash types/flags */ enum {