de38bfbbed
Track the correct change witness across chained joinsplits
8 years ago
9384e74c50
Closes #1833 . Format currency amounts in z_sendmany error message.
Improve coverage of possible error states from z_sendmany.
Refactor qa test for z_sendmany operations.
8 years ago
38276c6ba2
Add GenIdentity, an identity function for MappedShuffle.
We use this function in z_sendmany as part of the fix for #1779 .
8 years ago
7c463780cf
Fixes #1779 so that sending to multiple zaddrs no longer fails.
Commit 2eeb6b randomized the order of input and output notes,
but this is now known to prevent the chaining of multiple joinsplits
in a single transaction. The root cause has yet to be determined.
This patch is a temporary fix and disables the shuffling of input
and output notes. It also adds a chained joinsplit test to the
python qa test suite.
8 years ago
ad0ba9467d
Add assert to AsyncRPCOperation_sendmany
8 years ago
db026807b8
Add z_sendmany rule that when sending coinbase utxos to a zaddr
they must be consumed entirely, without any change, since there
is currently no way to specify a change address in z_sendmany.
8 years ago
10d1b90987
Fix incorrect error message in z_sendmany
8 years ago
446f867b4c
Add debug option "zrpcunsafe" to be used when logging more sensitive information such as the memo field of a note.
8 years ago
aa36398b27
Add more assertions, throw if find_output params are invalid
8 years ago
328d39d29c
Remove stale comment
8 years ago
2eeb6bebde
Randomize JoinSplits in z_sendmany
8 years ago
2b1cda3b6a
Return improved error message when trying to spend Coinbase coins ( #1373 ).
Extra parameter added to AvailableCoins to include or exclude Coinbase coins.
SelectCoins, used for sending taddr->taddr, will exclude Coinbase coins.
Added qa rpc test and a runtime parameter -regtestprotectcoinbase to enforce
the coinbase->zaddr consensus rule in regtest mode.
8 years ago
438d1e45be
Use -debug=zrpc for z_* rpc calls ( #1504 )
8 years ago
b11bb0e26a
Replace GetTxid() with GetHash()
8 years ago
e79ded8a47
Remove line of commented out code we don't need
8 years ago
dfc0080d06
Update comment with ticket issue number
8 years ago
1eb8789789
Add assert
8 years ago
ed42053a6c
Fix formatting
8 years ago
2ad0b7bfe2
Use zcash constants
8 years ago
b99d4f9b17
Improve error reporting when attempting to spend coinbase utxos.
8 years ago
9fb18458e8
Add assert for two mutually exclusive member variables.
8 years ago
cc59ac12a9
Add ticket number to issues raised in comment.
8 years ago
00edda4ac6
Remove unused varible.
8 years ago
a101ef7979
Update log statement to include fee.
8 years ago
1b141933e5
Rename GetUnspentNotes to GetFilteredNotes
Added parameter to ignore spent notes, which is true by default.
8 years ago
fc46069e81
Add more logging.
8 years ago
a9743bc8bf
Refactor async sendmany and getbalance calls to use GetUnspentNotes().
8 years ago
269310ce3c
Replace zcashParams_ with global.
8 years ago
5f8118c8a4
Revert "Reduce use of global pzcashParams with private member variable"
This reverts commit 4d71ba58d37eb4f93d68b5e437086ce14fb24825.
8 years ago
4b32c16ba5
Reduce use of global pzcashParams with private member variable
8 years ago
485145ea78
Disable proof generation when testmode is enabled in async SendMany operation.
8 years ago
4cff8a5c50
Fix typo in error message
8 years ago
9bb6162626
Add extra checking of memo data in hexadecimal string format.
8 years ago
a5905772c8
Add logging under the category "asyncrpc".
8 years ago
39c7f954d0
Remove redundant call.
8 years ago
15c83ac6b4
Remove redundant check when getting spending key for a payment address.
8 years ago
87f7c98795
Refactor to use wallet note tracking from commit a72379
8 years ago
c93d8bdf9c
Fix bug where call to sign and send a transaction was in wrong scope.
8 years ago
3fd5a615ac
Coinbase utxos can only be spent when sending to a single zaddr.
Change from the transaction will be sent to the same zaddr.
8 years ago
14af21e9f7
Add chaining of JoinSplits within a transaction.
8 years ago
3b54bf5813
Refactoring and small improvements to async rpc operations.
Added AsyncRPCQueue::closeAndWait() so rpcserver can block on worker threads when shutting down.
AsyncRPCOperation is no longer copyable - copy constructor and assignment operators now private.
Refactoring: renamed methods, renamed member variables
Tidy up: comments, const, size_t, braces
8 years ago
15d345466d
Successful result of z_sendmany returns txid so it doesn't need to return raw hex.
8 years ago
b7d7b2ad9d
z_sendmany from a taddr now routes change to a new address instead of back to the sender's taddr,
8 years ago
4876de6c6d
Update find_unspent_notes() as mapNoteAddrs_t has been replaced by mapNoteData_t.
8 years ago
dafb81614b
Implement z_sendmany RPC call.
Simple implementation does not try to optimize coin or note selection.
Caller can send from a taddr or zaddr to multiple recipients.
Currently only one of the recipients can be a zaddr.
8 years ago
fc72c078be
Add async RPC queue and operation classes.
Add z_getoperationstatus RPC command.
Add z_sendmany RPC command (dummy implementation, does not send actual
coins).
8 years ago
Simon