71043784dd
Auto merge of #1586 - bitcartel:z_sendmany_amount_too_strict, r=daira
Fix issue where z_sendmany amount parameter is too strict
Upstream treats an amount parameter of `1` the same as `1.0`. Third-party would like this fixed.
8 years ago
fd7ef7b632
Auto merge of #1584 - bitcartel:1504_zca_011_logging, r=daira
More granular control over logging of z_* calls
Closes #1504
8 years ago
10ad093bbb
Auto merge of #1567 - str4d:rename-binaries, r=daira
Rename binaries
This ensures that our installs don't clash with existing Bitcoin binaries and libraries.
Closes #1563 and #1565
8 years ago
deba66ca55
Fix other potential race conditions similar to ref #1597 in RPC tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
dc21a8a39f
Auto merge of #1578 - daira:1570.tromp-equihash-with-libsodium-blake.2, r=daira
1570.tromp equihash with libsodium blake.2
Remove BLAKE2b implementation from Tromp Equihash solver, and address almost all of @str4d's review comments on #1570 . Supercedes #1576 .
Signed-off-by: Daira Hopwood daira@jacaranda.org
8 years ago
f0f838f081
Fix race condition in rpc-tests/wallet_protectcoinbase.py. closes #1597
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
cd8e856df7
Auto merge of #1585 - bitcartel:1583_stop_test_writing_to_testnet3, r=daira
Closes #1583 by setting up the datadir for the wallet gtest.
Stops test writing to ~/.zcash/testnet3.
Also related to #1506
8 years ago
43f0769cf6
Fix build problem with coins_tests
8 years ago
abd22bb674
Add tests for CCoins deserialization
8 years ago
e9d221e764
CDataStream::ignore Throw exception instead of assert on negative nSize.
Previously disk corruption would cause an assert instead of an exception.
8 years ago
f588c5edd6
Fix OOM bug: UTXO entries with invalid script length
8 years ago
6fc5764eda
Treat overly long scriptPubKeys as unspendable
8 years ago
4c6ea562bd
Introduce constant for maximum CScript length
8 years ago
c99a1c7e4f
Auto merge of #1566 - daira:1557.make-v2-txns-standard, r=ageis
1557.make v2 txns standard
Make v2 transactions standard. This also corrects a rule about admitting large orphan transactions into the mempool, to account for v2-specific fields. ref #1557
8 years ago
323b8214c2
Auto merge of #1580 - str4d:1378-repair-witness-cache, r=daira
Clear witness cache when re-witnessing notes
Closes #1378
8 years ago
a514cb2968
Only send one GetAddr response per connection.
This conserves resources from abusive peers that just send
getaddr in a loop. Also makes correlating addr messages
against INVs less effective.
8 years ago
e496b2e391
net: Ignore `notfound` P2P messages
8 years ago
f19cb7b7ee
Revert "Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459"
This reverts commit a652e4183e
8 years ago
5d985da5c1
Repair check-security-hardening.sh.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
5eed758493
Update test to use integer amount as well as decimal amount when calling z_sendmany
8 years ago
75407c6872
Fix issue where z_sendmany is too strict and does not allow integer based amount e.g. 1 which is the same as 1.0
8 years ago
78293a9989
Auto merge of #1575 - arcalinea:document-rpc-security, r=daira
Document RPC security assumptions
Document RPC security assumptions in security-warnings.md #965
8 years ago
ffd2cb3437
Closes #1583 by setting up the datadir for the wallet gtest.
8 years ago
446f867b4c
Add debug option "zrpcunsafe" to be used when logging more sensitive information such as the memo field of a note.
8 years ago
e7b1f312f5
Add security warning about logging of z_* calls.
8 years ago
90031e1d61
Auto merge of #1577 - radix42:v1.0.0-rc1-gitian, r=daira
V1.0.0 rc1 gitian
Removes indeterminism from gitian builds: underlying processor instruction set variant of x86_64 was being detected by the libgmp autoconf process, which caused differences in libgmp and libsnark
8 years ago
f90526579b
Auto merge of #1569 - str4d:1552-disable-wallet-encryption, r=daira
Disable wallet encryption
Closes #1552
8 years ago
5f0009b2d2
Assert that the Equihash solver is a supported option.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
f91bbeedb7
Add help for -equihashsolver= option.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
d8e06e3f58
Add test that encryptwallet is disabled
8 years ago
bb891cb4a2
Auto merge of #1571 - daira:1459.avoid-boost-posix-time, r=daira
Avoid boost::posix_time functions that have potential out-of-bounds read bugs
ref #1459
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
2b499f4386
Fix RPC tests that require wallet encryption
8 years ago
ccc0f9af42
Fixes CID 1352714 uninitialized scalar variable.
8 years ago
8ecf6ccfef
Improve security documentation
8 years ago
fed6c83ccf
Fixes CID 1352727 uninitialized scalar variable.
8 years ago
351b38fd5b
Fixes CID 1352599 unitialized scalar variable
8 years ago
35cf6ee26d
Document another wallet encryption concern
8 years ago
43873535d4
Fixes CID 1352686 uninitialized scalar variable.
8 years ago
78376cacd4
Update RPC interfaces warnings language
8 years ago
19bec4d9bb
Fixes CID 1352715 uninitialized scalar field.
8 years ago
b7727d8b3b
Fixes CID 1352687 uninitialized scalar field.
8 years ago
b1c1a32b3a
Fixes CID 1352698 uninitialized scalar field.
8 years ago
9a4127e74c
Fixes CID 1352706 uninitialized scalar field.
8 years ago
2da03f897b
Fixes CID 1147436 uninitialized scalar field.
8 years ago
750d4e07dd
Document that wallet encryption is disabled
8 years ago
1532cb75f3
Throw an error when encryptwallet is disabled
8 years ago
b492ef3232
Auto merge of #1568 - str4d:1548-remove-block-index-tag, r=daira
Remove the RC 1 block index error message
Reverts 85457ddec1Closes #1548
8 years ago
a652e4183e
Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
8 years ago
1b407cba2b
Add heights to log output
8 years ago
878c4b1b50
Clear witness cache when re-witnessing notes
Closes #1378
8 years ago
zkbot