dfeec18b85
Test every numeric-accepting opcode for correct handling of the numeric minimal encoding rule
10 years ago
554147ad9e
Ensure MINIMALDATA invalid tests can only fail one way
Removes the need for the 'negated' versions of the tests, and ensures
other failures don't mask what we're trying to test.
10 years ago
6004e77b92
Improve CScriptNum() comment
Edited-by: Pieter Wuille <pieter.wuille@gmail.com>
10 years ago
698c6abb25
Add SCRIPT_VERIFY_MINIMALDATA (BIP62 rules 3 and 4)
Also use the new flag as a standard rule, and replace the IsCanonicalPush
standardness check with it (as it is more complete).
10 years ago
d752ba86c1
Add SCRIPT_VERIFY_SIGPUSHONLY (BIP62 rule 2)
10 years ago
f2e03ffae9
Update comments in chainparams to be doxygen compatible
10 years ago
2fdc3351d7
Update comments in chain to be doxygen compatible
10 years ago
7014f382e3
[Qt] Remove CAmount from BitcoinAmountField Q_PROPERTY
10 years ago
6261e6e6e0
getblockhash: throw JSONRPCError (not runtime_error)
10 years ago
a31e8bad53
Make CBlockIndex* returned by GetDepthInMainChain const.
Make the CBlockIndex* (optionally) returned by GetDepthInMainChain
const. This prevents accidental modification. The result is for
reading its properties rather than modifying it.
10 years ago
24f5c94015
Update comments in addrman to be doxygen compatible
Also correct the file license
10 years ago
7c0f36c431
Clear vFixedSeeds for regtest network
It shouldn't inherit these from testnet.
(seems to be already done for unit test network but forgotten here...)
Fixes #5127 .
10 years ago
3a757c5294
fix build with libc++ after 85c579e
10 years ago
d2833de424
qt: remove monitoreddatamapper
We haven't used the viewModified signal in ages, so we can use a normal
QDataWidgetMapper.
10 years ago
fa7361907a
boost: split stream classes out of serialize.h
serialization now has no dependencies.
10 years ago
a873823864
CAutoFile: Explicit Get() and remove unused methods
Also add documentation to some methods.
10 years ago
7b2bb96271
Replace some function names with __func__
10 years ago
33dfbf57d3
rpc: Fix leveldb iterator leak, and flush before `gettxoutsetinfo`
This fixes an iterator leak resulting in
bitcoind: db/version_set.cc:789: leveldb::VersionSet::~VersionSet(): Assertion `dummy_versions_.next_ == &dummy_versions_' failed."
exception on shutdown.
Also make sure to flush pcoinsTip before calling GetStats() to make
sure we apply them to the current height.
10 years ago
9acbb4180a
qt: small English language updates from translators
More friendly language, use placeholders where possible
10 years ago
6d3ab8564c
qt: English translation update after 0a08aa8
10 years ago
d29a2917ff
Rename RPC_TRANSACTION_* errors to RPC_VERIFY_* and use RPC_VERIFY_ERROR for submitblock
10 years ago
f877aaaf16
Bugfix: submitblock: Use a temporary CValidationState to determine accurately the outcome of ProcessBlock, now that it no longer does the full block validity check
10 years ago
24e8896430
Add CValidationInterface::BlockChecked notification
10 years ago
a3c26c2e85
Fixes for missing boost tuple.hpp header include.
10 years ago
b7ae2c172a
Chain::SetTip return type to void
10 years ago
a96d113962
Rename CWalletInterface to CValidationInterface
It's useful for much more than wallets.
10 years ago
fef24cab1a
Add IsNull() to class CAutoFile and remove operator !
10 years ago
85c579e3a6
script: add a slew of includes all around and drop includes from script.h
Lots of files ended up with indirect includes from script.h.
10 years ago
db8eb54bd7
script: move ToString and ValueString out of the header
10 years ago
e9ca4280f3
script: add ToByteVector() for converting anything with begin/end
This should move to a util header once their dependencies are cleaned up.
10 years ago
066e2a1403
script: move CScriptID to standard.h and add a ctor for creating them from CScripts
This allows for a reversal of the current behavior.
This:
CScript foo;
CScriptID bar(foo.GetID());
Becomes:
CScript foo;
CScriptID bar(foo);
This way, CScript is no longer dependent on CScriptID or Hash();
10 years ago
d4746d56c0
Add a SECURE style flag for ThreadSafeMessageBox, which indicates that the message contains sensitive information. This keeps the message from being output to the debug log by bitcoind. Fixes a possible security risk when starting bitcoind in server mode without the 'rpcpassword' option configured, resulting in the "suggested" password being output to the debug log.
10 years ago
e8ea0fd19e
MOVEONLY: CInPoint from core to txmempool
10 years ago
ca3ce0fa03
squashme on 3fdb9e8c (Bluematt's bikeshedding)
10 years ago
6f155bdb80
Add LIBTOOLFLAGS CXX tag to qt makefile include
Related #4993
10 years ago
5f4bcf6b14
boost: drop boost dependency in version.cpp.
Also add a test to verify.
10 years ago
352058e8b0
boost: drop boost dependency in utilstrencodings.cpp
10 years ago
e1c9467766
boost: drop boost dependency in core.cpp
10 years ago
e405aa48c7
boost: remove CPrivKey dependency from CECKey
This allows CECKey to be used without directly depending on the secure
allocators
10 years ago
52955068b7
boost: drop dependency on tuple in serialization
There's only one user of this form of serialization, so it can be easily
dropped. It could be re-added if desired when we switch to c++11.
10 years ago
1d9b86d584
boost: drop dependency on is_fundamental in serialization
There's only one case where a vector containing a fundamental type is
serialized all-at-once, unsigned char. Anything else would lead to
strange results.
Use a dummy argument to overload in that case.
10 years ago
e11b2ce4c6
Fix large reorgs
10 years ago
afc32c5eea
Fix rebuild-chainstate feature and improve its performance
Previous refactorings broke the ability to rebuild the chainstate by deleting the chainstate
directory, resulting in an incorrect "Incorrect or no genesis block found" error message. Fix
that.
Also, improve the performance of ActivateBestBlockStep by using the skiplist to only discover
a few potential blocks to connect at a time, instead of all blocks forever - as we likely bail
out after connecting a single one anyway.
10 years ago
16d5194165
Skip reindexed blocks individually
Instead of skipping to the last reindexed block in each file (which could
jump over processed out-of-order blocks), just skip each already processed
block individually.
10 years ago
ad96e7ccd9
Make -reindex cope with out-of-order blocks
Remember out-of-order block headers along with disk positions. This is
likely the simplest and least-impact way to make -reindex work with
headers first.
Based on top of #4468 .
10 years ago
e17bd58392
Rename setBlockIndexValid to setBlockIndexCandidates
10 years ago
1af838b339
Add height to "Requesting block" debug
10 years ago
1bcee67ee7
Better logging of stalling
10 years ago
4c93322923
Improve getheaders (sending) logging
10 years ago
f244c99c96
Remove CheckMinWork, as we always know all parent headers
10 years ago
Peter Todd