What this means is that there is a maximum number of addresses that are possible to create inside a single wallet.dat, roughly 2^31 addresses, since saplingAccountCounter is a uint32_t in our codebase.
We should probably just check for a huge value of saplingAccountCounter and then refuse to make any new addresses, before we get to the overflow value.
This affects Hush as well:
https://github.com/zcash/zcash/issues/5487
What this means is that there is a maximum number of addresses that are possible to create inside a single wallet.dat, roughly 2^31 addresses, since `saplingAccountCounter` is a uint32_t in our codebase.
We should probably just check for a huge value of saplingAccountCounter and then refuse to make any new addresses, before we get to the overflow value.
This affects Hush as well:
https://github.com/zcash/zcash/issues/5487
What this means is that there is a maximum number of addresses that are possible to create inside a single wallet.dat, roughly 2^31 addresses, since
saplingAccountCounteris a uint32_t in our codebase.We should probably just check for a huge value of saplingAccountCounter and then refuse to make any new addresses, before we get to the overflow value.
Upstream fix:
0da6bcef72