hush-cli getinfo does not show algo #146

Closed
opened 2 years ago by jahway603 · 8 comments
Collaborator

While testing the RandomX branch, I see the "algo": "randomx" field when running hush-cli -ac_name=RANDOMXXX getinfo but I do not see the "algo" field when running hush-cli getinfo on HUSH3 mainnet.

Would the "algo" field also be there for other HSCs?

While testing the RandomX branch, I see the `"algo": "randomx"` field when running `hush-cli -ac_name=RANDOMXXX getinfo` but I do not see the "algo" field when running `hush-cli getinfo` on HUSH3 mainnet. Would the "algo" field also be there for other HSCs?
Owner

@jahway603 currently the code for getinfo only shows an "algo" field if the algorithm is not Equihash. Should we instead just show the "algo" all the time, no matter what?

@jahway603 currently the code for getinfo only shows an "algo" field if the algorithm is not Equihash. Should we instead just show the "algo" all the time, no matter what?
Poster
Collaborator

@jahway603 currently the code for getinfo only shows an "algo" field if the algorithm is not Equihash. Should we instead just show the "algo" all the time, no matter what?

Would that field then just show equihash or randomx or would it specifically show the Equihash(n,k) type?

> @jahway603 currently the code for getinfo only shows an "algo" field if the algorithm is not Equihash. Should we instead just show the "algo" all the time, no matter what? Would that field then just show `equihash` or `randomx` or would it specifically show the Equihash(n,k) type?
Owner

@jahway603 I think it would be most useful if it showed the N+K values for equihash. Do you want to work on this? I can help

@jahway603 I think it would be most useful if it showed the N+K values for equihash. Do you want to work on this? I can help
Poster
Collaborator

@duke yeah, I'd like to work on this but not sure where to begin.

@duke yeah, I'd like to work on this but not sure where to begin.
Owner

@jahway603 use grep -r or ack to find the file that contains the getinfo RPC (hint, it's in a subdir of ./src/), then search for "algo" in that file to find the place where it adds that JSON key.

@jahway603 use `grep -r` or `ack` to find the file that contains the getinfo RPC (hint, it's in a subdir of ./src/), then search for "algo" in that file to find the place where it adds that JSON key.
Poster
Collaborator

PR #147 fixes this

PR https://git.hush.is/hush/hush3/pulls/147 fixes this
jahway603 self-assigned this 2 years ago
Poster
Collaborator

new PR #151 opened to get this into the dev branch

new PR https://git.hush.is/hush/hush3/pulls/151 opened to get this into the dev branch
Poster
Collaborator

this is now resolved

this is now resolved
jahway603 closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.