Sometimes build.sh -j N doesn't work because of a race condition
In file included from cryptoconditions/src/asn/Condition.h:17,
from cryptoconditions/src/cryptoconditions.c:19:
cryptoconditions/src/asn/SimpleSha256Condition.h:17:10: fatal error: OCTET_STRING.h: No such file or directory
17 | #include <OCTET_STRING.h>
| ^~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:2467: cryptoconditions/src/cryptoconditions.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
There needs to be a change to our Makefile which makes something depend on OCTET_STRING.h existing, such as cryptoconditions/src/asn/SimpleSha256Condition.h depending on OCTET_STRING.h existing, because OCTET_STRING.h is a generated file and sometimes the compiler tries to compile code that uses it, before it's been generated.
Sometimes `build.sh -j N` doesn't work because of a race condition
```
In file included from cryptoconditions/src/asn/Condition.h:17,
from cryptoconditions/src/cryptoconditions.c:19:
cryptoconditions/src/asn/SimpleSha256Condition.h:17:10: fatal error: OCTET_STRING.h: No such file or directory
17 | #include <OCTET_STRING.h>
| ^~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:2467: cryptoconditions/src/cryptoconditions.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
```
There needs to be a change to our Makefile which makes something depend on OCTET_STRING.h existing, such as `cryptoconditions/src/asn/SimpleSha256Condition.h` depending on `OCTET_STRING.h` existing, because `OCTET_STRING.h` is a generated file and sometimes the compiler tries to compile code that uses it, before it's been generated.
CC cryptoconditions/src/utils.o
cryptoconditions/src/utils.c:27:10: fatal error: cryptoconditions.h: No such file or directory
27 | #include "cryptoconditions.h"
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:2451: cryptoconditions/src/utils.o] Error 1
This is another form of the race condition:
```
CC cryptoconditions/src/utils.o
cryptoconditions/src/utils.c:27:10: fatal error: cryptoconditions.h: No such file or directory
27 | #include "cryptoconditions.h"
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:2451: cryptoconditions/src/utils.o] Error 1
```
Neither OCTET_STRING.h nor cryptoconditions.h are generated files, so something else is going on here.
My current guess is that src/cryptoconditions/src/utils.o needs src/cryptoconditions/src/cryptoconditions.o to exist first
Neither OCTET_STRING.h nor cryptoconditions.h are generated files, so something else is going on here.
My current guess is that `src/cryptoconditions/src/utils.o` needs `src/cryptoconditions/src/cryptoconditions.o` to exist first
I was hitting this on danger branch currently. First failed for missing OCTET_STRING.h, then cryptoconditions.h, and then OCTET_STRING.h again. I was using -j 2 at first and then also hit it again without specifying but it eventually compiled. Might be partially related to VPS as it's only 2 vCPUs and 4 GB RAM.
I was hitting this on `danger` branch currently. First failed for missing OCTET_STRING.h, then cryptoconditions.h, and then OCTET_STRING.h again. I was using `-j 2` at first and then also hit it again without specifying but it eventually compiled. Might be partially related to VPS as it's only 2 vCPUs and 4 GB RAM.
Sometimes
build.sh -j Ndoesn't work because of a race conditionThere needs to be a change to our Makefile which makes something depend on OCTET_STRING.h existing, such as
cryptoconditions/src/asn/SimpleSha256Condition.hdepending onOCTET_STRING.hexisting, becauseOCTET_STRING.his a generated file and sometimes the compiler tries to compile code that uses it, before it's been generated.This is another form of the race condition:
Neither OCTET_STRING.h nor cryptoconditions.h are generated files, so something else is going on here.
My current guess is that
src/cryptoconditions/src/utils.oneedssrc/cryptoconditions/src/cryptoconditions.oto exist firstI was hitting this on
dangerbranch currently. First failed for missing OCTET_STRING.h, then cryptoconditions.h, and then OCTET_STRING.h again. I was using-j 2at first and then also hit it again without specifying but it eventually compiled. Might be partially related to VPS as it's only 2 vCPUs and 4 GB RAM.This error will go away when the
dukebranch is merged, which removes libcryptoconditions entirely 🎉dukebranch is merged todev, this bug is now gone