dev branch now has a new RPC getrescaninfo that returns data related to rescanning, including starting height (for partial rescans), current rescan height and a rescan progress which is a double between 0 and 1.
@fekt please test this out and let me know if you find any bugs
`dev` branch now has a new RPC `getrescaninfo` that returns data related to rescanning, including starting height (for partial rescans), current rescan height and a rescan progress which is a double between 0 and 1.
@fekt please test this out and let me know if you find any bugs
I tried adding a method for this in SD similar to others like this: void RPC::getRescanInfo(const std::function<void(QJsonValue)>& cb)
When I call it I get a seg fault though. I could be overlooking something but I noticed it doesn't return JSON in an array and not sure if that's what's causing it.
I tried adding a method for this in SD similar to others like this:
`void RPC::getRescanInfo(const std::function<void(QJsonValue)>& cb)`
When I call it I get a seg fault though. I could be overlooking something but I noticed it doesn't return JSON in an array and not sure if that's what's causing it.
@duke I pushed everything here https://git.hush.is/fekt/SilentDragon
I was testing calling in connection.cpp since that's where I was testing rescan progress previously.
@duke I pushed everything here https://git.hush.is/fekt/SilentDragon
I was testing calling in connection.cpp since that's where I was testing rescan progress previously.
@fekt various RPC's return a single JSON hash, instead of an array, such as getinfo, so I am not sure. My guess is the flavor of JSON returned is causing this, such as returning a double/float instead of a string for progress. There are many incompatible versions of JSON and every library has their own flavor that they like. For instance, some JSON libraries consider duplicate keys invalid JSON, but some libraries don't care.
@fekt various RPC's return a single JSON hash, instead of an array, such as `getinfo`, so I am not sure. My guess is the flavor of JSON returned is causing this, such as returning a double/float instead of a string for progress. There are many incompatible versions of JSON and every library has their own flavor that they like. For instance, some JSON libraries consider duplicate keys invalid JSON, but some libraries don't care.
duke
Parsing debug.log to get rescan progress really sucks and is very error-prone. We should be able to get data about rescan progress via RPC.
devbranch now has a new RPCgetrescaninfothat returns data related to rescanning, including starting height (for partial rescans), current rescan height and a rescan progress which is a double between 0 and 1.@fekt please test this out and let me know if you find any bugs
I tried adding a method for this in SD similar to others like this:
void RPC::getRescanInfo(const std::function<void(QJsonValue)>& cb)When I call it I get a seg fault though. I could be overlooking something but I noticed it doesn't return JSON in an array and not sure if that's what's causing it.
@fekt can you push the code that is segfaulting to a branch so I can look at it?
@duke I pushed everything here https://git.hush.is/fekt/SilentDragon
I was testing calling in connection.cpp since that's where I was testing rescan progress previously.
@fekt various RPC's return a single JSON hash, instead of an array, such as
getinfo, so I am not sure. My guess is the flavor of JSON returned is causing this, such as returning a double/float instead of a string for progress. There are many incompatible versions of JSON and every library has their own flavor that they like. For instance, some JSON libraries consider duplicate keys invalid JSON, but some libraries don't care.Disregard. Doing it wrong and can't test calling it there the way I was. Doesn't crash when I call elsewhere.
getrescaninfonow exists and seems to work, closing this