I noticed the code differences when looking at how `doc/i2p.md` needed to change
i2p.cpp
https://github.com/bitcoin/bitcoin/commits/master/src/i2p.cpp
vs
https://git.hush.is/hush/hush3/commits/branch/master/src/i2p.cpp
i2p.h
https://github.com/bitcoin/bitcoin/commits/master/src/i2p.h
vs
https://git.hush.is/hush/hush3/commits/branch/master/src/i2p.h
@jahway603 this issue is about porting the documentation improvements from the pull request linked in the description. There are no functional changes, the changes to the code are just refactoring. The changes you mention to i2p.{cpp,h} are on the latest master branch of BTC, which may have additional changes. If you want to look at the difference between a file in our codebase versus in BTC I suggest running colordiff -u on the two files.
@jahway603 this issue is about porting the documentation improvements from the pull request linked in the description. There are no functional changes, the changes to the code are just refactoring. The changes you mention to i2p.{cpp,h} are on the latest master branch of BTC, which may have additional changes. If you want to look at the difference between a file in our codebase versus in BTC I suggest running `colordiff -u` on the two files.
0ed9cc5892dffa319457https://github.com/bitcoin/bitcoin/pull/26838/files
bitcoin's
src/i2p.handsrc/i2p.cpphave new code in them, so is this just a documentation change?@jahway603 I don't think I understand your question. Where are you seeing changes to i2p.h or i2p.cpp ?
I noticed the code differences when looking at how
doc/i2p.mdneeded to changei2p.cpp
https://github.com/bitcoin/bitcoin/commits/master/src/i2p.cpp
vs
https://git.hush.is/hush/hush3/commits/branch/master/src/i2p.cpp
i2p.h
https://github.com/bitcoin/bitcoin/commits/master/src/i2p.h
vs
https://git.hush.is/hush/hush3/commits/branch/master/src/i2p.h
@jahway603 this issue is about porting the documentation improvements from the pull request linked in the description. There are no functional changes, the changes to the code are just refactoring. The changes you mention to i2p.{cpp,h} are on the latest master branch of BTC, which may have additional changes. If you want to look at the difference between a file in our codebase versus in BTC I suggest running
colordiff -uon the two files.Closing as PR #359 resolved this issue