Track AddrMan totals by network and table #264

Open
opened 1 year ago by duke · 0 comments
duke commented 1 year ago
Owner

This BTC PR Review Club link is a very good introduction to the issue:

https://bitcoincore.reviews/26847

which is about https://github.com/bitcoin/bitcoin/pull/26847

The core problem that BTC has and we inherited is that if you abruptly change your -onlynet setting, for instance from -onlynet=onion to -onlynet=i2p you may get stuck with only "unreachable" peers in peers.dat and your node will not be able to get any outbound connections. The manual fix is to delete/move peers.dat and restart the node.

The better fix is for the node to keep track of peers by network and for it to realize that all peers in peers.dat are "unreachable" and know that it should try harder to find peers.

This BTC PR Review Club link is a very good introduction to the issue: https://bitcoincore.reviews/26847 which is about https://github.com/bitcoin/bitcoin/pull/26847 The core problem that BTC has and we inherited is that if you abruptly change your `-onlynet` setting, for instance from `-onlynet=onion` to `-onlynet=i2p` you may get stuck with only "unreachable" peers in peers.dat and your node will not be able to get any outbound connections. The manual fix is to delete/move peers.dat and restart the node. The better fix is for the node to keep track of peers by network and for it to realize that all peers in peers.dat are "unreachable" and know that it should try harder to find peers.
duke added the
bug
label 1 year ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.