hush
/
hush3
9
0
Fork 11
Code Issues 140 Pull Requests 2 Projects Releases 16 Wiki Activity
Labels Milestones
New Issue

Remove unused function CWalletTx::GetRequestCount #273

Closed
opened 1 year ago by duke · 4 comments
duke commented 1 year ago
Owner

In src/wallet/wallet.cpp and src/wallet/wallet.h

In src/wallet/wallet.cpp and src/wallet/wallet.h
jahway603 commented 1 year ago
Collaborator

After removing unused function CWalletTx::GetRequestCount in wallet.cpp and wallet.h, the changes have failed to build twice on both Ubuntu 20.04 and Debian 11 systems.

After removing unused function CWalletTx::GetRequestCount in wallet.cpp and wallet.h, the changes have failed to build twice on both Ubuntu 20.04 and Debian 11 systems.
duke commented 1 year ago
Poster
Owner

@jahway603 I have already done this in code that I haven't pushed yet

@jahway603 I have already done this in code that I haven't pushed yet
duke commented 1 year ago
Poster
Owner

done on duke branch

done on duke branch
duke closed this issue 1 year ago
jahway603 commented 1 year ago
Collaborator

oh, well I just tested with fresh git clone and it built fine on Ubuntu 20.04 and Debian 11...

oh, well I just tested with fresh git clone and it built fine on Ubuntu 20.04 and Debian 11...
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
arm
asyncnotedecryption
danger
dev
dev-aarch64
dev-mac
dev-old-randomx
divzaddrs
dragonx
duke
freebsd
getfilterednotes
hip39
insync
jahway603
master
mvstuff
onryo
p2p_privacy
ramhash
relaytx
rx-largepages
setbestchain
warmup
witness_cache
wolfssl
wolfssl_win
z_createrawtransaction
z_importwallet
z_signmessage
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it testing
related to testing tor
related to tor wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release testing tor wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes