This code could potentially speed up rescans by a large margin
miodrag has some interesting code at https://github.com/ycashfoundation/ycash/commit/5803ce2e5673da43b27599657aa9ea2b7262f640
This code could potentially speed up rescans by a large margin
I thought it would be easier to add than diversified addresses, but it's going down another rabbit hole where other things need to be changed as well. I'll apologize in advance for lots of minor commits, but I am coding on one PC and building on another, fixing one error at a time.
I know onryo was having issues with that RPC testing large wallets and wondering if there are any improvements that can be made to it. This is a diff against Pirate's but they still have Sprout junk: https://www.diffchecker.com/462pMMSa/
I started a branch here for this: https://git.hush.is/hush/hush3/src/branch/asyncnotedecryption
I thought it would be easier to add than diversified addresses, but it's going down another rabbit hole where other things need to be changed as well. I'll apologize in advance for lots of minor commits, but I am coding on one PC and building on another, fixing one error at a time.
I think I left off with it failing on `getalldata` here since decrypt is using more args now: https://git.hush.is/hush/hush3/src/branch/master/src/wallet/rpcwallet.cpp#L3084
I know onryo was having issues with that RPC testing large wallets and wondering if there are any improvements that can be made to it. This is a diff against Pirate's but they still have Sprout junk: https://www.diffchecker.com/462pMMSa/
@fekt lots of small commits are fine, they help identify exactly what commits breaks something and make things easier to revert.
I will take a look at the diff and see if I can offer help. I can assure you that doing this will be easier than diversified addresses, because this is not a consensus change, doesn't require changing Rust code and doesn't require a mandatory update on all nodes. I am sure there is a small rabbit hole here, but it will be much shallower than ZIP212
@fekt lots of small commits are fine, they help identify exactly what commits breaks something and make things easier to revert.
I will take a look at the diff and see if I can offer help. I can assure you that doing this will be easier than diversified addresses, because this is not a consensus change, doesn't require changing Rust code and doesn't require a mandatory update on all nodes. I am sure there is a small rabbit hole here, but it will be much shallower than ZIP212
miodrag has some interesting code at
5803ce2e56This code could potentially speed up rescans by a large margin
Is this the same as his PR to zcash here?
https://github.com/zcash/zcash/pull/6231
@jahway603 nope
I started a branch here for this: https://git.hush.is/hush/hush3/src/branch/asyncnotedecryption
I thought it would be easier to add than diversified addresses, but it's going down another rabbit hole where other things need to be changed as well. I'll apologize in advance for lots of minor commits, but I am coding on one PC and building on another, fixing one error at a time.
I think I left off with it failing on
getalldatahere since decrypt is using more args now: https://git.hush.is/hush/hush3/src/branch/master/src/wallet/rpcwallet.cpp#L3084I know onryo was having issues with that RPC testing large wallets and wondering if there are any improvements that can be made to it. This is a diff against Pirate's but they still have Sprout junk: https://www.diffchecker.com/462pMMSa/
@fekt lots of small commits are fine, they help identify exactly what commits breaks something and make things easier to revert.
I will take a look at the diff and see if I can offer help. I can assure you that doing this will be easier than diversified addresses, because this is not a consensus change, doesn't require changing Rust code and doesn't require a mandatory update on all nodes. I am sure there is a small rabbit hole here, but it will be much shallower than ZIP212