HACs connect to HUSH nodes by default #379

Closed
opened 3 months ago by fekt · 3 comments
fekt commented 3 months ago
Collaborator

I'm thinking this code should be modified for HACs so that they don't connect to HUSH nodes. This allows any HUSH nodes running a malicious HAC node to attack the HAC easily.
https://git.hush.is/hush/hush3/src/branch/master/src/hush_utils.h#L1806

Forcing HACs to only use -addnode/-connect or allowing a way to specify a domain name so the node list can be dynamic per HAC might be better. Open to other's thoughts.

I'm thinking this code should be modified for HACs so that they don't connect to HUSH nodes. This allows any HUSH nodes running a malicious HAC node to attack the HAC easily. https://git.hush.is/hush/hush3/src/branch/master/src/hush_utils.h#L1806 Forcing HACs to only use `-addnode`/`-connect` or allowing a way to specify a domain name so the node list can be dynamic per HAC might be better. Open to other's thoughts.
Owner

@fekt you bring up a good point. This code was inherited from upstream, which assumes that all blockchains using the code should trust the same servers. This is not a good assumption and does not match reality.

What if we change the code such that only HUSH mainnet and DRAGONX mainnet use those servers? Any other HAC's would not even try to connect to them.

@fekt you bring up a good point. This code was inherited from upstream, which assumes that all blockchains using the code should trust the same servers. This is not a good assumption and does not match reality. What if we change the code such that *only* HUSH mainnet and DRAGONX mainnet use those servers? Any other HAC's would not even try to connect to them.
duke added the
bug
label 3 months ago
Poster
Collaborator

That sounds fine to me. While we should all trust each other, it adds some plausible deniability and prevents any potential issues with other HACs connecting to our nodes by default.

That sounds fine to me. While we should all trust each other, it adds some plausible deniability and prevents any potential issues with other HACs connecting to our nodes by default.
Owner

@fekt latest commit on dev fixes this. Please test and then close this issue if it works correctly

@fekt latest commit on dev fixes this. Please test and then close this issue if it works correctly
fekt closed this issue 2 months ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.