hush
/
hush3
9
0
Fork 11
Code Issues 143 Pull Requests 3 Projects Releases 16 Wiki Activity
Labels Milestones
New Issue

build.h file referenced in 3.6.0 rpc/misc.cpp is missing #4

Closed
opened 3 years ago by jahway603 · 3 comments
jahway603 commented 3 years ago
Collaborator

This issue tracker is only for technical issues related to hushd

General Hush questions and/or support requests and are best directed to Telegram

Describe the issue

While compiling 3.6.0, I receive the following error message:
"rpc/misc.cpp:40:10: fatal error: build.h: No such file or directory"

Gitea does not contain this build.h.
The previous 3.5.2 release did not contain this build.h. It was also not referenced in that version's src/rpc/misc.cpp.

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. git clone the repo
  2. run "./build.sh"
  3. It then fails and complains of a missing file

Expected behaviour

It should build successfully.

Actual behaviour + errors

It does not build successfully.

The version of Komodo you were using:

N/A as it was not compiling

Machine specs:

  • OS name + version: Arch Linux (rolling)
  • CPU: AMD Ryzen 7 2700 Eight-Core @ 16x 3.2GHz
  • RAM: 32GB
  • Disk size: 2TB
  • Disk Type (HD/SDD): both
  • Linux kernel version (uname -a): 5.9.14-arch1-1
  • Compiler version (gcc -version): gcc (GCC) 10.2.0

Any extra information that might be useful in the debugging process.

N/A

<!--- Remove text and sections that do not apply --> This issue tracker is only for technical issues related to hushd General Hush questions and/or support requests and are best directed to [Telegram](https://hush.is/telegram_support) ### Describe the issue While compiling 3.6.0, I receive the following error message: "rpc/misc.cpp:40:10: fatal error: build.h: No such file or directory" Gitea does not contain this build.h. The previous 3.5.2 release did not contain this build.h. It was also not referenced in that version's src/rpc/misc.cpp. ### Can you reliably reproduce the issue? #### If so, please list the steps to reproduce below: 1. git clone the repo 2. run "./build.sh" 3. It then fails and complains of a missing file ### Expected behaviour It should build successfully. ### Actual behaviour + errors It does not build successfully. ### The version of Komodo you were using: N/A as it was not compiling ### Machine specs: - OS name + version: Arch Linux (rolling) - CPU: AMD Ryzen 7 2700 Eight-Core @ 16x 3.2GHz - RAM: 32GB - Disk size: 2TB - Disk Type (HD/SDD): both - Linux kernel version (uname -a): 5.9.14-arch1-1 - Compiler version (gcc -version): gcc (GCC) 10.2.0 ### Any extra information that might be useful in the debugging process. N/A
👍 1
duke was assigned by jahway603 3 years ago
duke commented 3 years ago
Owner

@jahway603 maybe this is a good bug for you to hunt.

I added the "build_date" of the full node to getinfo output, which means our hand-written code now includes build.h in our source code, but I didn't declare the dependency in the build system.

This means that for large -j, there is a race condition and build.h doesn't exist yet. I haven't been able to trigger it but @radix42 reported the same problem even with no -j building on windows, so this is indeed a real bug and @jahway603 gets the "25 HUSH first official bug in 3.6.0" merit badge 🤘

@jahway603 maybe this is a good bug for you to hunt. I added the "build_date" of the full node to getinfo output, which means our hand-written code now includes build.h in our source code, but I didn't declare the dependency in the build system. This means that for large -j, there is a race condition and build.h doesn't exist yet. I haven't been able to trigger it but @radix42 reported the same problem even with no -j building on windows, so this is indeed a real bug and @jahway603 gets the "25 HUSH first official bug in 3.6.0" merit badge :metal:
👍 1 ❤️ 1
duke commented 3 years ago
Owner

I believe we need to declare that misc.cpp requires build.h as a dependency in configure.ac or one of it's buddies

I believe we need to declare that misc.cpp requires build.h as a dependency in configure.ac or one of it's buddies
duke commented 3 years ago
Owner

Fixed in dev branch, closing @jahway603

Fixed in `dev` branch, closing @jahway603
duke closed this issue 3 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
arm
asyncnotedecryption
danger
dev
dev-aarch64
dev-mac
dev-old-randomx
divzaddrs
dragonx
duke
freebsd
getfilterednotes
hip39
hushutils
insync
jahway603
master
mvstuff
onryo
p2p_privacy
ramhash
relaytx
rx-largepages
setbestchain
warmup
witness_cache
wolfssl
wolfssl_win
z_createrawtransaction
z_importwallet
z_signmessage
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it testing
related to testing tor
related to tor wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release testing tor wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
duke
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes