LWD crashes: tx-overwinter-expired #61

Closed
opened 2 weeks ago by onryo · 5 comments
onryo commented 2 weeks ago
Collaborator

lwd crashes, hush3 runs fine.

From lwd:

{"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"error with %!s(MISSING) rpc, retrying...sendrawtransaction","retry":44,"time":"2024-04-19T12:36:21+02:00"}
{"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"error with %!s(MISSING) rpc, retrying...sendrawtransaction","retry":40,"time":"2024-04-19T12:36:32+02:00"}
{"app":"lightwalletd","level":"info","msg":"Waiting for block: 1747954","time":"2024-04-19T12:36:45+02:00"}
{"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"error with %!s(MISSING) rpc, retrying...sendrawtransaction","retry":48,"time":"2024-04-19T12:37:25+02:00"}
{"app":"lightwalletd","level":"info","msg":"Waiting for block: 1747955","time":"2024-04-19T12:37:34+02:00"}
{"app":"lightwalletd","level":"fatal","msg":"unable to issue %!s(MISSING) RPC call to hushd nodesendrawtransaction","time":"2024-04-19T12:37:50+02:00","timeouts":51}

From hush3:

2024-04-19 19:39:20 ERROR: ContextualCheckTransaction(): transaction cc4a284ff0d72e2b3d4702dd7c6a9c6502c8361caea26a214486558a8cd918e5 is expired, expiry block 1748374 vs current block 1748386
2024-04-19 19:37:53 ERROR: ContextualCheckTransaction(): transaction f640c71f18e9932b6e366f2673324ef4bac6d609910ac73fbbacf8c29e6c76a7 is expired, expiry block 1748363 vs current block 1748384
2024-04-19 19:37:53 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed
2024-04-19 19:38:05 ERROR: ContextualCheckTransaction(): transaction a7097697988316d1782082dc136d62de8c536d4c07a66ef6cb7844c46d7ee18b is expired, expiry block 1748370 vs current block 1748384
2024-04-19 19:38:05 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed
2024-04-19 19:38:09 ERROR: ContextualCheckTransaction(): transaction d3586e3fecaa37cf3c1daf15f1f15d2cd7de617d1dd72dcd7c4e8ec77c97b938 is expired, expiry block 1748315 vs current block 1748384
2024-04-19 19:38:09 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed
2024-04-19 19:39:05 ERROR: ContextualCheckTransaction(): transaction c5cdd006097c5c5c1795e734eae7c0188ed11a663add0540fdaae1086a57700e is expired, expiry block 1748384 vs current block 1748385
2024-04-19 19:39:05 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed
2024-04-19 19:39:20 ERROR: ContextualCheckTransaction(): transaction cc4a284ff0d72e2b3d4702dd7c6a9c6502c8361caea26a214486558a8cd918e5 is expired, expiry block 1748374 vs current block 1748386
2024-04-19 19:39:20 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed
2024-04-19 19:39:28 ERROR: ContextualCheckTransaction(): transaction 66c7855245324ced4631fb4a29cf2e5b83fdaf0eec4749a2912aec04fb3af52e is expired, expiry block 1748352 vs current block 1748386
2024-04-19 19:39:28 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed
2024-04-19 19:39:45 ERROR: ContextualCheckTransaction(): transaction 270ade877ce20a95859f24e6a1ca99b13232fcf9ae0d20406c06390c83e090c6 is expired, expiry block 1748348 vs current block 1748387
2024-04-19 19:39:45 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed
2024-04-19 19:39:46 ERROR: ContextualCheckTransaction(): transaction 74f49c891aef2069589d62f95b42241469ea90150d4a1bee835b5a51b40972de is expired, expiry block 1748367 vs current block 1748387
lwd crashes, hush3 runs fine. From lwd: ``` {"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"error with %!s(MISSING) rpc, retrying...sendrawtransaction","retry":44,"time":"2024-04-19T12:36:21+02:00"} {"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"error with %!s(MISSING) rpc, retrying...sendrawtransaction","retry":40,"time":"2024-04-19T12:36:32+02:00"} {"app":"lightwalletd","level":"info","msg":"Waiting for block: 1747954","time":"2024-04-19T12:36:45+02:00"} {"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"error with %!s(MISSING) rpc, retrying...sendrawtransaction","retry":48,"time":"2024-04-19T12:37:25+02:00"} {"app":"lightwalletd","level":"info","msg":"Waiting for block: 1747955","time":"2024-04-19T12:37:34+02:00"} {"app":"lightwalletd","level":"fatal","msg":"unable to issue %!s(MISSING) RPC call to hushd nodesendrawtransaction","time":"2024-04-19T12:37:50+02:00","timeouts":51} ``` From hush3: ``` 2024-04-19 19:39:20 ERROR: ContextualCheckTransaction(): transaction cc4a284ff0d72e2b3d4702dd7c6a9c6502c8361caea26a214486558a8cd918e5 is expired, expiry block 1748374 vs current block 1748386 2024-04-19 19:37:53 ERROR: ContextualCheckTransaction(): transaction f640c71f18e9932b6e366f2673324ef4bac6d609910ac73fbbacf8c29e6c76a7 is expired, expiry block 1748363 vs current block 1748384 2024-04-19 19:37:53 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed 2024-04-19 19:38:05 ERROR: ContextualCheckTransaction(): transaction a7097697988316d1782082dc136d62de8c536d4c07a66ef6cb7844c46d7ee18b is expired, expiry block 1748370 vs current block 1748384 2024-04-19 19:38:05 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed 2024-04-19 19:38:09 ERROR: ContextualCheckTransaction(): transaction d3586e3fecaa37cf3c1daf15f1f15d2cd7de617d1dd72dcd7c4e8ec77c97b938 is expired, expiry block 1748315 vs current block 1748384 2024-04-19 19:38:09 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed 2024-04-19 19:39:05 ERROR: ContextualCheckTransaction(): transaction c5cdd006097c5c5c1795e734eae7c0188ed11a663add0540fdaae1086a57700e is expired, expiry block 1748384 vs current block 1748385 2024-04-19 19:39:05 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed 2024-04-19 19:39:20 ERROR: ContextualCheckTransaction(): transaction cc4a284ff0d72e2b3d4702dd7c6a9c6502c8361caea26a214486558a8cd918e5 is expired, expiry block 1748374 vs current block 1748386 2024-04-19 19:39:20 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed 2024-04-19 19:39:28 ERROR: ContextualCheckTransaction(): transaction 66c7855245324ced4631fb4a29cf2e5b83fdaf0eec4749a2912aec04fb3af52e is expired, expiry block 1748352 vs current block 1748386 2024-04-19 19:39:28 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed 2024-04-19 19:39:45 ERROR: ContextualCheckTransaction(): transaction 270ade877ce20a95859f24e6a1ca99b13232fcf9ae0d20406c06390c83e090c6 is expired, expiry block 1748348 vs current block 1748387 2024-04-19 19:39:45 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed 2024-04-19 19:39:46 ERROR: ContextualCheckTransaction(): transaction 74f49c891aef2069589d62f95b42241469ea90150d4a1bee835b5a51b40972de is expired, expiry block 1748367 vs current block 1748387 ```
Owner

Latest code on dev branch tries to deal with this by making sendrawtransaction the only RPC that is allowed to fail all retries without making the lite server shutdown.

The code could be much better. Ideally it should check for an expired tx error and not do any retries at all but doing that is more complex code. What I wrote is a simple hack to hopefully make the lite server usable.

Latest code on dev branch tries to deal with this by making `sendrawtransaction` the only RPC that is allowed to fail all retries without making the lite server shutdown. The code could be much better. Ideally it should check for an expired tx error and not do any retries at all but doing that is more complex code. What I wrote is a simple hack to hopefully make the lite server usable.
Poster
Collaborator

I restarted the server with recent changes 20 hours ago, seems to be stable.

From the logs:

{"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"error with sendrawtransaction rpc, retrying...","retry":50,"time":"2024-04-21T18:00:17+02:00"}
{"app":"lightwalletd","level":"info","msg":"Waiting for block: 1750490","time":"2024-04-21T18:00:37+02:00"}
{"app":"lightwalletd","level":"info","msg":"Waiting for block: 1750491","time":"2024-04-21T18:00:55+02:00"}
{"app":"lightwalletd","level":"info","msg":"Waiting for block: 1750492","time":"2024-04-21T18:01:33+02:00"}
{"app":"lightwalletd","level":"info","msg":"Waiting for block: 1750493","time":"2024-04-21T18:04:20+02:00"}
{"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"giving up on sendrawtransaction rpc","retry":51,"time":"2024-04-21T18:04:37+02:00"}

Thank you for fixing this problem fast.

I restarted the server with recent changes 20 hours ago, seems to be stable. From the logs: ``` {"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"error with sendrawtransaction rpc, retrying...","retry":50,"time":"2024-04-21T18:00:17+02:00"} {"app":"lightwalletd","level":"info","msg":"Waiting for block: 1750490","time":"2024-04-21T18:00:37+02:00"} {"app":"lightwalletd","level":"info","msg":"Waiting for block: 1750491","time":"2024-04-21T18:00:55+02:00"} {"app":"lightwalletd","level":"info","msg":"Waiting for block: 1750492","time":"2024-04-21T18:01:33+02:00"} {"app":"lightwalletd","level":"info","msg":"Waiting for block: 1750493","time":"2024-04-21T18:04:20+02:00"} {"app":"lightwalletd","error":"-26: 16: tx-overwinter-expired","level":"warning","msg":"giving up on sendrawtransaction rpc","retry":51,"time":"2024-04-21T18:04:37+02:00"} ``` Thank you for fixing this problem fast.
Owner

@onryo great to hear. Going to close this now, make a new issue if problems arise with the new code

@onryo great to hear. Going to close this now, make a new issue if problems arise with the new code
duke closed this issue 2 weeks ago
Collaborator

I had the same issue and am also now trying the dev branch code

I had the same issue and am also now trying the dev branch code
duke commented 1 week ago
Owner

@jahway603 sounds good. All light wallet node operators will need to update (since whatever is generating these expired txs is going to connect to various servers) and we should make a new release as long as you don't find any issues.

@jahway603 sounds good. All light wallet node operators will need to update (since whatever is generating these expired txs is going to connect to various servers) and we should make a new release as long as you don't find any issues.
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.