Not compiling on Ubuntu 20.04 #17

Having trouble building both master and dev branches on Ubuntu 20.04 (rustc 1.61.0), but they both build fine on Arch Linux (rustc 1.64.0).

Here is the full backtrace from master branch on Ubuntu 20.04. Anyone else having any build issues?

$ RUST_BACKTRACE=full make build
cargo build --release
   Compiling silentdragonlitelib v0.1.0 (/home/XXX/dev/silentdragonlite-cli/lib)
error: failed to run custom build command for `silentdragonlitelib v0.1.0 (/home/XXX/dev/silentdragonlite-cli/lib)`

Caused by:
  process didn't exit successfully: `/home/XXX/dev/silentdragonlite-cli/target/release/build/silentdragonlitelib-9906409a1b2b6eae/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /home/XXX/.cargo/registry/src/github.com-1ecc6299db9ec823/tonic-build-0.1.1/src/lib.rs:226:14
  stack backtrace:
     0:     0x56474c8d18dc - std::backtrace_rs::backtrace::libunwind::trace::h4f7e6efa76dce8a2
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
     1:     0x56474c8d18dc - std::backtrace_rs::backtrace::trace_unsynchronized::hfd3fb3f24f83e846
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
     2:     0x56474c8d18dc - std::sys_common::backtrace::_print_fmt::h82538af9e683b729
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/sys_common/backtrace.rs:66:5
     3:     0x56474c8d18dc - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::had12b8ebc27ab529
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/sys_common/backtrace.rs:45:22
     4:     0x56474c8f2d1e - core::fmt::write::hcef9c23bf27d039c
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/core/src/fmt/mod.rs:1194:17
     5:     0x56474c8bb9f1 - std::io::Write::write_fmt::h91d3c48a0b4c64c6
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/io/mod.rs:1655:15
     6:     0x56474c8bea75 - std::sys_common::backtrace::_print::h792686924b255848
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/sys_common/backtrace.rs:48:5
     7:     0x56474c8bea75 - std::sys_common::backtrace::print::ha62ed1347274eaea
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/sys_common/backtrace.rs:35:9
     8:     0x56474c8bea75 - std::panicking::default_hook::{{closure}}::hc107e5bad7c99d87
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:295:22
     9:     0x56474c8be729 - std::panicking::default_hook::h38856b877e172286
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:314:9
    10:     0x56474c8bf1c3 - std::panicking::rust_panic_with_hook::h66309baf5235212f
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:702:17
    11:     0x56474c8d1c17 - std::panicking::begin_panic_handler::{{closure}}::h3a147548aa082356
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:588:13
    12:     0x56474c8d19f4 - std::sys_common::backtrace::__rust_end_short_backtrace::hcc62583c733bef84
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/sys_common/backtrace.rs:138:18
    13:     0x56474c8bebd2 - rust_begin_unwind
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:584:5
    14:     0x56474c653733 - core::panicking::panic_fmt::h8531284c14f462dc
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/core/src/panicking.rs:143:14
    15:     0x56474c6537c3 - core::result::unwrap_failed::h6972a430d3981bcd
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/core/src/result.rs:1785:5
    16:     0x56474c68a78a - core::result::Result<T,E>::unwrap::h856790e019f3e63f
    17:     0x56474c687545 - tonic_build::fmt::h8a77b177e4d19143
    18:     0x56474c65fe89 - tonic_build::Builder::compile::h12adafb6dea80f4f
    19:     0x56474c68475d - build_script_build::main::h8283add917f0ae81
    20:     0x56474c683886 - core::ops::function::FnOnce::call_once::hd92e78f2b0ae3fa8
    21:     0x56474c65ff39 - std::sys_common::backtrace::__rust_begin_short_backtrace::hdb81f8babf3b9206
    22:     0x56474c6832bc - std::rt::lang_start::{{closure}}::h767bf7807bdcabe5
    23:     0x56474c8b95f1 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::ha0ec212ab4f77f16
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/core/src/ops/function.rs:259:13
    24:     0x56474c8b95f1 - std::panicking::try::do_call::h48607f7552c924c2
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:492:40
    25:     0x56474c8b95f1 - std::panicking::try::h3160b7d5b765f2dc
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:456:19
    26:     0x56474c8b95f1 - std::panic::catch_unwind::h15dc3d510a1565a5
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panic.rs:137:14
    27:     0x56474c8b95f1 - std::rt::lang_start_internal::{{closure}}::h8251d7c301e52521
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/rt.rs:128:48
    28:     0x56474c8b95f1 - std::panicking::try::do_call::h621f5a74981e2493
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:492:40
    29:     0x56474c8b95f1 - std::panicking::try::h19e8eec73d818e1d
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panicking.rs:456:19
    30:     0x56474c8b95f1 - std::panic::catch_unwind::h445c334789a64dcc
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/panic.rs:137:14
    31:     0x56474c8b95f1 - std::rt::lang_start_internal::h0b83bd2f4c5c32a0
                                 at /build/rustc-8kCV4J/rustc-1.61.0+dfsg1~llvm/library/std/src/rt.rs:128:20
    32:     0x56474c6832a1 - std::rt::lang_start::h45ef841257166c05
    33:     0x56474c684813 - main
    34:     0x7ff4efffe083 - __libc_start_main
    35:     0x56474c65398e - _start
    36:                0x0 - <unknown>
make: *** [Makefile:17: build] Error 101

Discovered this issue while trying to fix Issue #15

@jahway603 The master branch builds for me on Ubuntu 19.04 with rust 1.56.0 and then I reproduced your bug with Ubuntu 18.04 and rust 1.61.0

When I looked at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/tonic-build-0.1.1/src/lib.rs I see that it is trying to run a command called rustfmt which seems to be missing in rust 1.61.0 and is a part of rustup .

I am currently compiling rustup from source (it's taking a while) so I can install rustfmt and see if that changes things

I confirmed that where things worked on Ubuntu 19.04 I had rustup installed and rustfmt was in my PATH.

When I installed rustup on Ubuntu 18.04 it installed rust 1.65 and since rustup and rustfmt existed, the compile worked.

@jahway603 sounds like we should check if rustfmt exists to avoid this shitty error

It built and worked fine on Ubuntu 20.04 after installing rustfmt.

That makes sense why it worked on Arch, since I have rustup on that system.

Commit 7ed0cec1b0 has a build.sh that will check for build dependencies

@jahway603 awesome, thanks for working on this