Browse Source

Merge pull request #1 from rex4539/typos

Fix typos and cleanup
duke
adityapk00 5 years ago
committed by GitHub
parent
commit
d43426acf4
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      README.md
  2. 4
      docker/Dockerfile
  3. 4
      lib/src/paper.rs
  4. 2
      qtlib/src/lib.rs

6
README.md

@ -5,12 +5,12 @@ zecpaperwallet is a Zcash Sapling paper wallet generator that can run completely
zecpaperwallet is available as pre-built binaries from our [release page](https://github.com/adityapk00/zecpaperwallet/releases). Download the zip file for your platform, extract it and run the `./zecpaperwallet` binary.
# Generating wallets
To generate a zcash paper wallet, simply run `./zecpaperwallet`
To generate a Zcash paper wallet, simply run `./zecpaperwallet`
You'll be asked to type some random characters that will add entropy to the random number generator. Run with `--help` to see all options
## Saving as PDFs
To generate a zcash paper wallet and save it as a PDF, run
To generate a Zcash paper wallet and save it as a PDF, run
`./zecpaperwallet -z 3 --format pdf zecpaper-output.pdf`
This will generate 3 shielded z-addresses and their corresponding private keys, and save them in a PDF file called `zecpaper-output.pdf`
@ -20,7 +20,7 @@ zecpaperwallet is built with rust. To compile from source, you [install Rust](ht
```
curl https://sh.rustup.rs -sSf | sh
```
Chekout the zecpaperwallet repository and build the CLI
Checkout the zecpaperwallet repository and build the CLI
```
git clone https://github.com/adityapk00/zecpaperwallet.git
cd zecpaperwallet/cli

4
docker/Dockerfile

@ -1,5 +1,5 @@
FROM rust:1.34
LABEL Description="Rust compile env for linux + windows (cross)"
LABEL Description="Rust compile env for Linux + Windows (cross)"
RUN apt update
RUN apt install -y build-essential mingw-w64 gcc-aarch64-linux-gnu
@ -8,7 +8,7 @@ RUN rustup target add x86_64-pc-windows-gnu
RUN rustup target add x86_64-unknown-linux-musl
RUN rustup target add aarch64-unknown-linux-gnu
# Append the linker to the cargo config for windows cross compile
# Append the linker to the cargo config for Windows cross compile
RUN echo "[target.x86_64-pc-windows-gnu]" >> /usr/local/cargo/config && \
echo "linker = '/usr/bin/x86_64-w64-mingw32-gcc'" >> /usr/local/cargo/config

4
lib/src/paper.rs

@ -50,7 +50,7 @@ pub fn generate_wallet(testnet: bool, nohd: bool, count: u32, user_entropy: &[u8
*
* Note that cointype is 1 for testnet and 133 for mainnet
*
* get_seed is a closure that will take the address number being derived, and return a tuple cointaining the
* get_seed is a closure that will take the address number being derived, and return a tuple containing the
* seed and child number to use to derive this wallet.
*
* It is useful if we want to reuse (or not) the seed across multiple wallets.
@ -217,7 +217,7 @@ mod tests {
}
/*
Test data was derived from zcashd. It cointains 20 sets of seeds, and for each seed, it contains 5 accounts that are derived for the testnet and mainnet.
Test data was derived from zcashd. It contains 20 sets of seeds, and for each seed, it contains 5 accounts that are derived for the testnet and mainnet.
We'll use the same seed and derive the same set of addresses here, and then make sure that both the address and private key matches up.
To derive the test data, add something like this in test_wallet.cpp and run with

2
qtlib/src/lib.rs

@ -20,7 +20,7 @@ pub extern fn rust_generate_wallet(testnet: bool, count: u32, entropy: *const c_
}
/**
* Callers that recieve string return values from other functions should call this to return the string
* Callers that receive string return values from other functions should call this to return the string
* back to rust, so it can be freed. Failure to call this function will result in a memory leak
*/
#[no_mangle]

Loading…
Cancel
Save