forked from hush/hush3
Browse Source
Fix potentially misleading test failures This is in response to https://github.com/zcash/zcash/pull/3590#discussion_r224677644 Currently statements such as: ```assert_equal("Embarassment", "Embarrassment", "Misspelling detected")``` Will produce essentially the following error: ``` Assertion failed: Misspelling detected; expected: <Embarassment> but was: <Embarrassment> File "/home/eirik/Development/zcash/qa/rpc-tests/test_framework/test_framework.py", line 121, in main self.run_test() File "/home/eirik/Development/zcash/qa/rpc-tests/test_spelling.py", line 13, in run_test ``` Which is misleading because the item on the left is not what is actually expected. This PR changes the assertion failure to be displayed as: ``` Assertion failed: (left == right); Misspelling detected left: <Embarassment> right: <Embarrassment> File "/home/eirik/Development/zcash/qa/rpc-tests/test_framework/test_framework.py", line 121, in main self.run_test() File "/home/eirik/Development/zcash/qa/rpc-tests/test_spelling.py", line 13, in run_test ```metaverse
Homu
6 years ago
1 changed files with 3 additions and 3 deletions
Loading…
Reference in new issue