update for hush3 dev branch; no mo cumodo #21
Closed
oDinZu
wants to merge 1 commits from oDinZu:odinzu-sd
into dev
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'oDinZu:odinzu-sd'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Reference to error #20
This has fixed my SD launching dilemma on hush3:dev branch. 🥳
All of these komodo names didn't "need" to be changed, but since we making the change anyhow, went ahead and updated all komodo psuedonyms to match hush3 dev future.
@odinzu this is a very nice PR, but it needs a little more, because life is complex! Let me explain.
I made a similar change for
hushd
except we need to support people using the old "legacy" directory of~/.komodo/HUSH3
or the new~/.hush/HUSH3
. With your current PR as is, people who have existing HUSH nodes will not be able to use SD without doing a move/copy of the directory to the new place. Many people will not be able to do this.So in the
dev
branch, the logic is like this:~/.hush/HUSH3
exists, use that (even if legacy dir exists)~/.komodo/HUSH3
exists, use that~/.hush/HUSH3
dir (for new clones/installs)With the above logic:
mkdir ~/.hush; cp -R ~/.komodo/HUSH3 ~/.hush
~/.hush/HUSH3
and never know about this complexitySo this PR needs to have a few if/else statements to do the same logic as you can see here: https://git.hush.is/hush/hush3/src/branch/dev/src/util.cpp#L570
I implemented this and this PR creates conflicts with that, so I am closing