update for hush3 dev branch; no mo cumodo #21

Closed
oDinZu wants to merge 1 commits from oDinZu:odinzu-sd into dev
oDinZu commented 3 years ago

Reference to error #20

This has fixed my SD launching dilemma on hush3:dev branch. 🥳

All of these komodo names didn't "need" to be changed, but since we making the change anyhow, went ahead and updated all komodo psuedonyms to match hush3 dev future.

Reference to error #20 This has fixed my SD launching dilemma on hush3:dev branch. 🥳 All of these komodo names didn't "need" to be changed, but since we making the change anyhow, went ahead and updated all komodo psuedonyms to match hush3 dev future.
oDinZu added 1 commit 3 years ago
Owner

@odinzu this is a very nice PR, but it needs a little more, because life is complex! Let me explain.

I made a similar change for hushd except we need to support people using the old "legacy" directory of ~/.komodo/HUSH3 or the new ~/.hush/HUSH3. With your current PR as is, people who have existing HUSH nodes will not be able to use SD without doing a move/copy of the directory to the new place. Many people will not be able to do this.

So in the dev branch, the logic is like this:

  • If ~/.hush/HUSH3 exists, use that (even if legacy dir exists)
  • Else, if ~/.komodo/HUSH3 exists, use that
  • If neither exist, use the new ~/.hush/HUSH3 dir (for new clones/installs)

With the above logic:

  • Old existing installations will still work correctly with new hushd/SD
  • People can "upgrade" by doing mkdir ~/.hush; cp -R ~/.komodo/HUSH3 ~/.hush
    • The above keeps a backup of their data which I think is safer than moving the dir, fyi
  • Brand new users will blissfully use ~/.hush/HUSH3 and never know about this complexity

So this PR needs to have a few if/else statements to do the same logic as you can see here: https://git.hush.is/hush/hush3/src/branch/dev/src/util.cpp#L570

@odinzu this is a very nice PR, but it needs a little more, because life is complex! Let me explain. I made a similar change for `hushd` except we need to support people using the old "legacy" directory of `~/.komodo/HUSH3` or the new `~/.hush/HUSH3`. With your current PR as is, people who have existing HUSH nodes will not be able to use SD without doing a move/copy of the directory to the new place. Many people will not be able to do this. So in the `dev` branch, the logic is like this: * If `~/.hush/HUSH3` exists, use that (even if legacy dir exists) * Else, if `~/.komodo/HUSH3` exists, use that * If neither exist, use the new `~/.hush/HUSH3` dir (for new clones/installs) With the above logic: * Old existing installations will still work correctly with new hushd/SD * People can "upgrade" by doing `mkdir ~/.hush; cp -R ~/.komodo/HUSH3 ~/.hush` * The above keeps a backup of their data which I think is safer than moving the dir, fyi * Brand new users will blissfully use `~/.hush/HUSH3` and never know about this complexity So this PR needs to have a few if/else statements to do the same logic as you can see here: https://git.hush.is/hush/hush3/src/branch/dev/src/util.cpp#L570
Owner

I implemented this and this PR creates conflicts with that, so I am closing

I implemented this and this PR creates conflicts with that, so I am closing
duke closed this pull request 2 years ago
oDinZu deleted branch odinzu-sd 2 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Loading…
There is no content yet.