"Information about Hush" tab #105

Closed
opened 1 year ago by onryo · 11 comments
onryo commented 1 year ago
Collaborator

What is the purpose of this bigass image in our "Information about Hush" tab?

image

It makes more sense to remove it completely and have all info presented on the right somewhere in the middle or even remove the entire tab and move the info to Help->Info.

What is the purpose of this bigass image in our "Information about Hush" tab? ![image](/attachments/d00df09a-3937-49bf-9371-f30fcb4d51d8) It makes more sense to remove it completely and have all info presented on the right somewhere in the middle or even remove the entire tab and move the info to `Help->Info`.
174 KiB
onryo added the
question
label 1 year ago
fekt commented 1 year ago
Collaborator

When I was working on SDX I noticed this uses a custom class to scale the image as window resizes. The white is a background color that can be set dynamically based on theme like I recently added for SDX. I think it looks better setting it to the same background color. This is also scaled as small as it will go on wind0ze and looks better than full screen.

I've thought about the orange logo in the past and it might be good to update or remove it, unless for nostalgia. With SDX eventually being released, I think a logo here might make sense just so you can easily tell what wallet you're using since the themes are all the same. It could probably also be made smaller and make the info area larger with additional useful info. Anonset would be nice here.

When I was working on SDX I noticed this uses a custom class to scale the image as window resizes. The white is a background color that can be set dynamically based on theme like I recently added for SDX. I think it looks better setting it to the same background color. This is also scaled as small as it will go on wind0ze and looks better than full screen. ![](https://git.hush.is/attachments/bd67cc9e-a57a-4f2e-8c70-d7f9be4c7aab) I've thought about the orange logo in the past and it might be good to update or remove it, unless for nostalgia. With SDX eventually being released, I think a logo here might make sense just so you can easily tell what wallet you're using since the themes are all the same. It could probably also be made smaller and make the info area larger with additional useful info. Anonset would be nice here.
44 KiB
duke commented 1 year ago
Owner

@fekt thanks for fixing the white background color bug, it always annoyed me and I never could figure that out.

I am not attached to the orange logo, it can be changed to whatever people want.

@onryo there is no real need for an image but I agree with @fekt that it is good for branding and just looks better. The real "purpose" of the "Information" tab is for users to be able to take a screenshot of it and send it to us for debugging. It only contains data that is safe to share, i.e. no IP addresses, no file paths (which often have usernames/real names), no txid's, no addresses, etc.

The amount of work to move this data somewhere doesn't seem worth it.

@fekt thanks for fixing the white background color bug, it always annoyed me and I never could figure that out. I am not attached to the orange logo, it can be changed to whatever people want. @onryo there is no real need for an image but I agree with @fekt that it is good for branding and just looks better. The real "purpose" of the "Information" tab is for users to be able to take a screenshot of it and send it to us for debugging. It only contains data that is safe to share, i.e. no IP addresses, no file paths (which often have usernames/real names), no txid's, no addresses, etc. The amount of work to move this data somewhere doesn't seem worth it.
fekt commented 1 year ago
Collaborator

Looks like this now. 50% smaller in UI. I made logo same color has logo on Hushchat tab in dark themes so it's still visible on light themes without having to colorize it. Can set to different logo if needed.

Looks like this now. 50% smaller in UI. I made logo same color has logo on Hushchat tab in dark themes so it's still visible on light themes without having to colorize it. Can set to different logo if needed. ![](https://git.hush.is/attachments/dc3401f8-9463-4d73-8448-a0d058145753)
duke commented 1 year ago
Owner

@fekt looks way better!

@fekt looks way better!
Poster
Collaborator

Oh yeah, it's perfect, grey logo suits it well with "dark" theme.

Oh yeah, it's perfect, grey logo suits it well with "dark" theme.
duke commented 1 year ago
Owner

@fekt can you do the same graphics improvement you did here to the SD dev branch ? Or tell me which commits I can look at to the do the same thing

@fekt can you do the same graphics improvement you did here to the SD `dev` branch ? Or tell me which commits I can look at to the do the same thing
fekt commented 1 year ago
Collaborator

@duke I'll commit to SD tonight. SD already has most of the changes. Just the logo and changing the size in UI needs to be added I think.

@duke I'll commit to SD tonight. SD already has most of the changes. Just the logo and changing the size in UI needs to be added I think.
Collaborator

@onryo this didn't get in the 1.5.3 release but the changelog states that it did. I'm seeing orange in 1.5.3.

@onryo this didn't get in the 1.5.3 release but the changelog states that it did. I'm seeing orange in 1.5.3.
Poster
Collaborator

@onryo this didn't get in the 1.5.3 release but the changelog states that it did. I'm seeing orange in 1.5.3.

Are you sure? Because it was changed.

> @onryo this didn't get in the 1.5.3 release but the changelog states that it did. I'm seeing orange in 1.5.3. Are you sure? Because it was changed.
Collaborator

@onryo can this be closed since the correct image is in the SDL 1.5.3 release?

@onryo can this be closed since the correct image is in the SDL 1.5.3 release?
duke commented 1 year ago
Owner

calling this done

calling this done
duke closed this issue 1 year ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.