Not all assets/colors change when switching theme unless restarting #108

Open
opened 1 year ago by fekt · 2 comments
fekt commented 1 year ago
Collaborator

I noticed this when porting over some UI/theme tweaks from SD. It is more noticeable on the main Hush Chat screen when switching between dark and light themes. The image colors do not change unless restarting the app.

I noticed this when porting over some UI/theme tweaks from SD. It is more noticeable on the main Hush Chat screen when switching between dark and light themes. The image colors do not change unless restarting the app.
duke commented 1 year ago
Owner

@fekt there is likely a way to make things refresh without restarting. If I had to guess, some kind of CSS details are not being refreshed when the theme changes.

@fekt there is likely a way to make things refresh without restarting. If I had to guess, some kind of CSS details are not being refreshed when the theme changes.
fekt commented 1 year ago
Poster
Collaborator

@duke Yes, there is code there that's supposed to refresh the theme without restarting. It partially works. It seemed like it might not work for assets where the color is changed in code based on the theme but I didn't dig too much. It works fine in SD but not SDL.

There are some slight differences in SDL I'll need to check on. The theme names are capitalized in SDL but lowercase in SD and could be related but this issue existed before I ported over changes.

@duke Yes, there is code there that's supposed to refresh the theme without restarting. It partially works. It seemed like it might not work for assets where the color is changed in code based on the theme but I didn't dig too much. It works fine in SD but not SDL. There are some slight differences in SDL I'll need to check on. The theme names are capitalized in SDL but lowercase in SD and could be related but this issue existed before I ported over changes.
onryo added the
bug
label 1 year ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.