hush
/
SilentDragonLite
9
1
Fork 4
Code Issues 38 Pull Requests Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

'FirstTimeWizard::initializePage' hides overloaded virtual function #117

Closed
opened 1 year ago by duke · 3 comments
duke commented 1 year ago
Owner

It would be nice to deal with this compile warning, which maybe is related to some buggy behavior :

src/firsttimewizard.h:33:18: warning: 'FirstTimeWizard::initializePage' hides overloaded virtual function [-Woverloaded-virtual]
    virtual void initializePage();
It would be nice to deal with this compile warning, which maybe is related to some buggy behavior : ``` src/firsttimewizard.h:33:18: warning: 'FirstTimeWizard::initializePage' hides overloaded virtual function [-Woverloaded-virtual] virtual void initializePage(); ```
duke commented 1 year ago
Poster
Owner

I only see this with clang LLVM version 9.1.0 (clang-902.0.39.1)

It doesn't happen with gcc 8.3.0

I only see this with clang LLVM version 9.1.0 (clang-902.0.39.1) It doesn't happen with gcc 8.3.0
onryo added the
build
 label 1 year ago
fekt commented 1 year ago
Collaborator

I recall seeing this and looking into it awhile back. It seemed like it was a warning that could be ignored and gets thrown by clang for any virtual functions as a precaution. QT defines it that way: https://doc.qt.io/qt-5/qwizardpage.html#initializePage

I recall seeing this and looking into it awhile back. It seemed like it was a warning that could be ignored and gets thrown by clang for any virtual functions as a precaution. QT defines it that way: https://doc.qt.io/qt-5/qwizardpage.html#initializePage
duke commented 1 year ago
Poster
Owner

@fekt ok, I don't think this is worth worrying about. Closing

@fekt ok, I don't think this is worth worrying about. Closing
duke closed this issue 1 year ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
blake3
danger
denio
dev
duke
hushchat
import_zecw
jahway603
language
master
mempool
onryo
qtjson
recurring_on
rescanheight
russian
show_server
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes