Info tab doesn't show current server #118

Open
opened 1 year ago by duke · 7 comments
duke commented 1 year ago
Owner

If the internals of SDL saw a down server and used getRandomServer() to connect to a new one, the GUI info tab doesn't show the correct server. This is confusing for users and makes dev debugging confusing as well.

If the internals of SDL saw a down server and used `getRandomServer()` to connect to a new one, the GUI info tab doesn't show the correct server. This is confusing for users and makes dev debugging confusing as well.
Collaborator

Also from #86:

If stickyServer is set to true in "Information about Hush" it displays always "False".
image
From .config/Hush/SilentDragonLite.conf:

[connection]
server=https://lite.hush.land

[options]
...
stickyServer=true
Also from https://git.hush.is/hush/SilentDragonLite/issues/86#issuecomment-3762: > If `stickyServer` is set to `true` in "Information about Hush" it displays always "False". > ![image](/attachments/42c0da5a-62a8-44cb-b66f-ef8268e0eb73) > From `.config/Hush/SilentDragonLite.conf`: > ``` >[connection] >server=https://lite.hush.land > >[options] > ... >stickyServer=true >```
duke commented 1 year ago
Poster
Owner

@onryo thanks for finding that other issue. I think there are 2 bugs, one with stickyServer=true and one with it false. But they are related.

@onryo thanks for finding that other issue. I think there are 2 bugs, one with stickyServer=true and one with it false. But they are related.
duke commented 1 year ago
Poster
Owner

Latest commit on dev a080d0ca80 should now update the current server when it changes. Note that it only updates when the rest of GUI data updates, so it may still show the old server until the next refresh of data.

Latest commit on dev https://git.hush.is/hush/SilentDragonLite/commit/a080d0ca80d757519367a38a480caee0fb1f0173 should now update the current server when it changes. Note that it only updates when the rest of GUI data updates, so it may still show the old server until the next refresh of data.
onryo added the
bug
label 1 year ago
duke commented 1 year ago
Poster
Owner

@onryo does the latest code fix this issue?

@onryo does the latest code fix this issue?
Collaborator

No. @duke

image

[connection]
server=https://lite.hush.community

[options]
allowcheckupdates=true
allowfetchprices=true
currency_name=false
stickyServer=true
theme_name=Dark
No. @duke ![image](/attachments/34a78b8e-58d1-4a72-80ae-da6554ced8a8) ``` [connection] server=https://lite.hush.community [options] allowcheckupdates=true allowfetchprices=true currency_name=false stickyServer=true theme_name=Dark ```
duke commented 1 year ago
Poster
Owner

@onryo ok, to clarify, I meant "does it show the current server even when it selects a random server when a server is down?" I haven't tried to fix the bug with stickyServer yet

@onryo ok, to clarify, I meant "does it show the current server even when it selects a random server when a server is down?" I haven't tried to fix the bug with stickyServer yet
Collaborator

@onryo ok, to clarify, I meant "does it show the current server even when it selects a random server when a server is down?" I haven't tried to fix the bug with stickyServer yet

It displays the initial server, the actual connection to the server is not visible in "Current Server".

image

doAutoConnect  server= "https://lite.hush.community"
Wallet exists: true
doAutoConnect : using existing wallet
litelib_process_response :  Error: grpc-status: Internal, grpc-message: "Unexpected compression flag: 60"
getRandomServer
Checking if lite server  "https://lite.hush.land"  is a alive, try= 1
Reading wallet version 9
litelib_process_response :  OK
Choosing lite server  "https://lite.hush.land"
Reading wallet version 9
litelib_process_response :  OK
doAutoConnect : Successfully connected to random server:  "https://lite.hush.land"  !!!
> @onryo ok, to clarify, I meant "does it show the current server even when it selects a random server when a server is down?" I haven't tried to fix the bug with stickyServer yet It displays the initial server, the actual connection to the server is not visible in "Current Server". ![image](/attachments/653d0cc4-866c-4cb5-b917-eac071cbdca1) ``` doAutoConnect server= "https://lite.hush.community" Wallet exists: true doAutoConnect : using existing wallet litelib_process_response : Error: grpc-status: Internal, grpc-message: "Unexpected compression flag: 60" getRandomServer Checking if lite server "https://lite.hush.land" is a alive, try= 1 Reading wallet version 9 litelib_process_response : OK Choosing lite server "https://lite.hush.land" Reading wallet version 9 litelib_process_response : OK doAutoConnect : Successfully connected to random server: "https://lite.hush.land" !!! ```
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.