hush
/
SilentDragonLite
9
1
Fork 4
Code Issues 38 Pull Requests Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

[feature] Let user configure transaction (tx) fee in wallet GUI #121

Closed
opened 11 months ago by jahway603 · 5 comments
jahway603 commented 11 months ago
Collaborator

Let user configure transaction (tx) fee in wallet GUI

Let user configure transaction (tx) fee in wallet GUI
onryo added the
feature
 label 11 months ago
duke commented 11 months ago
Owner

How will a user know what non-default fee they should use?

How will a user know what non-default fee they should use?
fekt commented 11 months ago
Collaborator

The fee can be set by the user in SilentDragon in the bottom left of the Send screen. It defaults to 0.0001 and labeled as Miner Fee. What's in SD can probably be ported over to SDL.

The fee can be set by the user in SilentDragon in the bottom left of the Send screen. It defaults to 0.0001 and labeled as Miner Fee. What's in SD can probably be ported over to SDL.
fekt commented 11 months ago
Collaborator

I checked SDL and the fee field is already there. It's not editable and likely has none of the code to handle a custom fee like SD. SD warns a custom fee is being on the send confirmation popup.

I checked SDL and the fee field is already there. It's not editable and likely has none of the code to handle a custom fee like SD. SD warns a custom fee is being on the send confirmation popup.
👍 2
duke commented 4 months ago
Owner

It seems that we should unify SD+SDL to both be able to use a custom fee. It's not clear if SDL internals like silentdragonlite-cli or lightwalletd need to change to support this.

It seems that we should unify SD+SDL to both be able to use a custom fee. It's not clear if SDL internals like silentdragonlite-cli or lightwalletd need to change to support this.
👍 1
lucretius commented 3 months ago
Collaborator

we have this in the dev branch now: 49d587cd42 i think the issue can be closed

we have this in the dev branch now: https://git.hush.is/hush/SilentDragonLite/commit/49d587cd4290594d836c3cb8d3af1574ad1b47f7 i think the issue can be closed
👍 3
duke closed this issue 3 months ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
blake3
danger
denio
dev
duke
hushchat
import_zecw
jahway603
language
master
mempool
onryo
qtjson
recurring_on
rescanheight
russian
show_server
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes