hush
/
SilentDragonLite
9
1
Fork 4
Code Issues 38 Pull Requests Projects Releases 8 Wiki Activity
Labels Milestones
New Issue

[Feature Request] Change build.sh to enable building on more than 2 cores on Linux #137

Closed
opened 4 months ago by jahway603 · 3 comments
jahway603 commented 4 months ago
Collaborator

Change build.sh to enable building on more than 2 cores on Linux, as seen here https://git.hush.is/hush/SilentDragonLite/src/branch/master/build.sh#L8

Change build.sh to enable building on more than 2 cores on Linux, as seen here https://git.hush.is/hush/SilentDragonLite/src/branch/master/build.sh#L8
duke self-assigned this 3 months ago
duke commented 3 months ago
Owner

It sounds like we want the same behavior as hush3.git build.sh where you can do build.sh -j4 or any custom number of cores for compiling. I will work on this.

It sounds like we want the same behavior as hush3.git `build.sh` where you can do `build.sh -j4` or any custom number of cores for compiling. I will work on this.
duke commented 3 months ago
Owner

On a system I tested this new code on, with 8 CPU threads, using build.sh -j9 was about 25% faster than the default of build.sh when doing a fresh compile after a make clean . The reason we don't see a larger speedup is because libsodium was already hardcoded to use 8 threads and compiling that dependency takes a lot of time.

If you only modify SDL code and then recompile with build.sh -jN there will be a larger speedup.

On a system I tested this new code on, with 8 CPU threads, using `build.sh -j9` was about 25% faster than the default of `build.sh` when doing a fresh compile after a `make clean` . The reason we don't see a larger speedup is because libsodium was already hardcoded to use 8 threads and compiling that dependency takes a lot of time. If you only modify SDL code and then recompile with `build.sh -jN` there will be a larger speedup.
duke closed this issue 3 months ago
duke commented 3 months ago
Owner

Slightly related: Compiling libsodium on macs was hardcoded to 4 jobs which is now changed to 8, so compiling on macs will be faster now.

Slightly related: Compiling libsodium on macs was hardcoded to 4 jobs which is now changed to 8, so compiling on macs will be faster now.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
blake3
danger
denio
dev
duke
hushchat
import_zecw
jahway603
language
master
mempool
onryo
qtjson
recurring_on
rescanheight
russian
show_server
Labels
Apply labels
Clear labels
0-500 bounty
bounty up to 500 HUSH 2001-5000 bounty
bounty between 2001 and 5000 HUSH 501-2000 bounty
bounty between 501 and 2000 HUSH arm
something doesn't work on arm beginners
for new developers bug
may or may not be a bug build
problems building documentation
not enough information feature
new feature high priority
high priority i2p
related to i2p low priority
low priority medium priority
medium priority question
something is not clear release
release label or issue related to it tor
related to tor translation
translation update windows
related to windows wontfix
this won't be fixed
No Label 0-500 bounty 2001-5000 bounty 501-2000 bounty arm beginners bug build documentation feature high priority i2p low priority medium priority question release tor translation windows wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
duke
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes