Currently nothing checks if the version of QT being used to compile is compatible with our code. We do this for most important dependencies and we should do the same for QT.
I think in the distant past I have maybe seen our code compile on QT 5.11 and maybe even QT 5.10 but I don't think any current dev is using a system with stuff that old. We know that QT 5.12 works well with our code and we have at least one dev that tests against that, so we should declare 5.12 as the minimum version needed for our code.
Once we have this, it will be easy in the future to decide to increase our minimum version of QT required.
Currently nothing checks if the version of QT being used to compile is compatible with our code. We do this for most important dependencies and we should do the same for QT.
I think in the distant past I have maybe seen our code compile on QT 5.11 and maybe even QT 5.10 but I don't think any current dev is using a system with stuff that old. We know that QT 5.12 works well with our code and we have at least one dev that tests against that, so we should declare 5.12 as the minimum version needed for our code.
Once we have this, it will be easy in the future to decide to increase our minimum version of QT required.
This code should also detect somebody attempting to compile with QT6 and bail out early. I don't know if anybody has ever tried it and I doubt it would work.
This code should also detect somebody attempting to compile with QT6 and bail out early. I don't know if anybody has ever tried it and I doubt it would work.
Currently nothing checks if the version of QT being used to compile is compatible with our code. We do this for most important dependencies and we should do the same for QT.
I think in the distant past I have maybe seen our code compile on QT 5.11 and maybe even QT 5.10 but I don't think any current dev is using a system with stuff that old. We know that QT 5.12 works well with our code and we have at least one dev that tests against that, so we should declare 5.12 as the minimum version needed for our code.
Once we have this, it will be easy in the future to decide to increase our minimum version of QT required.
Done in commit
68d9388c1bwhich is ondevbranch, closingThis code should also detect somebody attempting to compile with QT6 and bail out early. I don't know if anybody has ever tried it and I doubt it would work.