Currently the SDL "Receive" screen defaults to taddr, and now that we are z2z, it no longer makes sense to have taddrs on that screen at all. There is no more option between zaddr and taddr, so we should remove the radio button and only show zaddr receiving addresses.
Solo miners and mining pools likely use hush-cli getnewaddress to get new taddrs to mine to, but it's possible they use this tab of SDL to generate new taddrs. We may need an area where users can generate new taddrs for mining, but it doesn't make sense on a "Receive" tab.
@jahway603@onryo@zanzibar@pj6969 your feedback on UI/UX implications of this stuff would help. Should we make a new tab for managing "mining addresses" or something like that?
Currently the SDL "Receive" screen defaults to taddr, and now that we are z2z, it no longer makes sense to have taddrs on that screen at all. There is no more option between zaddr and taddr, so we should remove the radio button and only show zaddr receiving addresses.
Solo miners and mining pools likely use `hush-cli getnewaddress` to get new taddrs to mine to, but it's possible they use this tab of SDL to generate new taddrs. We may need an area where users can generate new taddrs for mining, but it doesn't make sense on a "Receive" tab.
@jahway603 @onryo @zanzibar @pj6969 your feedback on UI/UX implications of this stuff would help. Should we make a new tab for managing "mining addresses" or something like that?
I left zaddr radio button for now because its checked status controls loading z-addrs in dropdown. There was also a bug where it was setting it to checked on send(2) tab instead of receive(3). Guessing tabs were moved around at some point in the past.
Removed in this commit to dev branch:
https://git.hush.is/hush/SilentDragonLite/commit/364c775d6d9a4f73ca5b98e9d278db3d576ee4b0
I left zaddr radio button for now because its checked status controls loading z-addrs in dropdown. There was also a bug where it was setting it to checked on send(2) tab instead of receive(3). Guessing tabs were moved around at some point in the past.
@fekt thanks for working on this! So is it the case now that there is no way to make a taddr via the SDL GUI? Maybe some solo miner or pool was relying on that feature? Should we make some other way to make a taddr via the GUI? I am on the fence about it.
@fekt thanks for working on this! So is it the case now that there is no way to make a taddr via the SDL GUI? Maybe some solo miner or pool was relying on that feature? Should we make some other way to make a taddr via the GUI? I am on the fence about it.
I didn't really look around a whole lot, but I believe there is no way to create a taddr now via SDL GUI with this change. I am not sure it's needed either. I think anyone solo mining or running a pool knows enough to be able to create a new address via cli if needed. I personally don't even use SDL. If we do add something, I'd maybe bury somewhere as a menu option.
I didn't really look around a whole lot, but I believe there is no way to create a taddr now via SDL GUI with this change. I am not sure it's needed either. I think anyone solo mining or running a pool knows enough to be able to create a new address via cli if needed. I personally don't even use SDL. If we do add something, I'd maybe bury somewhere as a menu option.
Currently the SDL "Receive" screen defaults to taddr, and now that we are z2z, it no longer makes sense to have taddrs on that screen at all. There is no more option between zaddr and taddr, so we should remove the radio button and only show zaddr receiving addresses.
Solo miners and mining pools likely use
hush-cli getnewaddressto get new taddrs to mine to, but it's possible they use this tab of SDL to generate new taddrs. We may need an area where users can generate new taddrs for mining, but it doesn't make sense on a "Receive" tab.@jahway603 @onryo @zanzibar @pj6969 your feedback on UI/UX implications of this stuff would help. Should we make a new tab for managing "mining addresses" or something like that?
Removed in this commit to dev branch:
364c775d6dI left zaddr radio button for now because its checked status controls loading z-addrs in dropdown. There was also a bug where it was setting it to checked on send(2) tab instead of receive(3). Guessing tabs were moved around at some point in the past.
@fekt thanks for working on this! So is it the case now that there is no way to make a taddr via the SDL GUI? Maybe some solo miner or pool was relying on that feature? Should we make some other way to make a taddr via the GUI? I am on the fence about it.
I didn't really look around a whole lot, but I believe there is no way to create a taddr now via SDL GUI with this change. I am not sure it's needed either. I think anyone solo mining or running a pool knows enough to be able to create a new address via cli if needed. I personally don't even use SDL. If we do add something, I'd maybe bury somewhere as a menu option.
@fekt I agree. I am going to close this issue and make another issue for enabling the creation of taddrs somewhere in the SDL GUI