Sweep funds from old private key format #23

Closed
opened 3 years ago by duke · 3 comments
duke commented 3 years ago
Owner

Requested by someone in Hush Support channel. Would be much easier than using hushd CLI, which is currently what people must do, because the SD GUI import is broken for bizarre reasons.

Requested by someone in Hush Support channel. Would be much easier than using hushd CLI, which is currently what people must do, because the SD GUI import is broken for bizarre reasons.
Poster
Owner

Since SDL recently learned how to import taddr/zaddr privkeys not in the current wallet and "sweep" the funds out, this is very close to being implemented. No GUI changes are required. The code needs to recognize old style privkeys by their prefix, (starting with 5, K or L) and then correctly extract the same private key.

Since SDL recently learned how to import taddr/zaddr privkeys not in the current wallet and "sweep" the funds out, this is very close to being implemented. No GUI changes are required. The code needs to recognize old style privkeys by their prefix, (starting with 5, K or L) and then correctly extract the same private key.
Poster
Owner

This is now implemented on the danger branch. The frontend supports uncompressed privkeys that start with 5, but the backend does not support them. Hush full node doesn't seem to support that format either and normal users will likely never see that format, so this seems to do what is needed.

Users who exported private keys from hushd or the Old Hush Web Wallet That Shall Not Be Named, will have private keys that start with K or L and thus will be supported by SDL.

This is now implemented on the `danger` branch. The frontend supports uncompressed privkeys that start with 5, but the backend does not support them. Hush full node doesn't seem to support that format either and normal users will likely never see that format, so this seems to do what is needed. Users who exported private keys from hushd or the Old Hush Web Wallet That Shall Not Be Named, will have private keys that start with K or L and thus will be supported by SDL.
Poster
Owner

This is in 1.5.0 , closing

This is in 1.5.0 , closing
duke closed this issue 3 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.